Disallow descriptions on root operation mappings#4393
Merged
Conversation
Contributor
Test ReportTest Results
Code Coverage (Java 25)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the stale SDL grammar allowance for descriptions directly before schema root operation type mappings, e.g. inside
schema { "desc" query: Query }.This aligns GraphQL Java with the GraphQL spec and graphql-js: schema definitions can have descriptions, but
RootOperationTypeDefinition/OperationTypeDefinitionitself does not.Background
The
description?onoperationTypeDefinitionwas introduced by PR #706 while adding block strings and SDL descriptions from issue #685. It appears to have been a broad grammar change rather than intentional support for root operation mapping descriptions: the parser never preserved this description onOperationTypeDefinition, and the AST printer/schema generator do not expose it.Tests
./gradlew test --tests graphql.parser.SDLParserTest