Skip to content

Add executable description support#4392

Merged
andimarek merged 1 commit into
masterfrom
fix-executable-descriptions
May 20, 2026
Merged

Add executable description support#4392
andimarek merged 1 commit into
masterfrom
fix-executable-descriptions

Conversation

@andimarek
Copy link
Copy Markdown
Member

@andimarek andimarek commented May 20, 2026

Summary

  • add executable grammar support for descriptions on operation, variable, and fragment definitions
  • preserve those descriptions on executable AST nodes and print them in non-compact AST output
  • keep query shorthand description-free and cover validation behavior

Fixes #4077

Testing

  • ./gradlew test --rerun-tasks --tests graphql.parser.ParserTest --tests graphql.language.AstPrinterTest --tests graphql.ParseAndValidateTest --tests graphql.parser.SDLParserTest --tests graphql.schema.idl.SchemaParserTest

@andimarek andimarek mentioned this pull request May 20, 2026
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

Test Report

Test Results

Java Version Total Passed Failed Errors Skipped
Java 11 5855 (+4 🟢) 5799 (+4 🟢) 0 (±0) 0 (±0) 56 (±0)
Java 17 5855 (+4 🟢) 5798 (+4 🟢) 0 (±0) 0 (±0) 57 (±0)
Java 21 5855 (+4 🟢) 5798 (+4 🟢) 0 (±0) 0 (±0) 57 (±0)
Java 25 5855 (+4 🟢) 5798 (+4 🟢) 0 (±0) 0 (±0) 57 (±0)
jcstress 32 (±0) 32 (±0) 0 (±0) 0 (±0) 0 (±0)
Total 23452 (+16 🟢) 23225 (+16 🟢) 0 (±0) 0 (±0) 227 (±0)

Code Coverage (Java 25)

Metric Covered Missed Coverage vs Master
Lines 29635 3130 90.4% ±0.0%
Branches 8706 1532 85.0% ±0.0%
Methods 7912 1210 86.7% ±0.0%

Changed Class Coverage (4 classes)

Class Line Branch Method
g.l.AstPrinter +0.1% 🟢 +0.5% 🟢 +0.1% 🟢
g.l.FragmentDefinition
$Builder		 +1.6% 🟢 ±0.0% +2.2% 🟢
g.l.OperationDefinition
$Builder		 +0.9% 🟢 ±0.0% +1.3% 🟢
g.l.VariableDefinition
$Builder		 +0.8% 🟢 ±0.0% +1.1% 🟢

Full HTML report: build artifact jacoco-html-report

Updated: 2026-05-20 08:17:33 UTC

@andimarek andimarek merged commit 3b03d75 into master May 20, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New spec change: Add descriptions to executable documents

1 participant

@andimarek