Fix spec303 flaky failure in ordered publisher TCK tests#4293
Merged
Conversation
The ordered subscriber's drain loop (emptyInFlightQueueIfWeCan) calls onNext for every completed CF in a while loop. With per-element executors, multiple CFs can complete concurrently, so the drain loop calls onNext multiple times on the same thread — the TCK flags this as a spec303 (unbounded recursion) violation. Fix: use a shared single-thread executor per publisher instead of a new executor per element. This ensures CFs complete sequentially, so when the drain loop runs on the executor thread, no other CFs can complete (they're queued behind it), and the loop only processes one item. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
Test ReportTest Results
Code Coverage (Java 25)
Changed Class Coverage (951 classes)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec303_mustNotAllowUnboundedRecursionfailure on Java 11 inCompletionStageMappingOrderedPublisherTckVerificationTestemptyInFlightQueueIfWeCan) callsonNextfor every completed CF in a while loop. With per-element executors (onenewSingleThreadExecutor()per mapper call), multiple CFs complete concurrently on different threads. When the drain loop runs, it finds several completed CFs and callsonNextmultiple times on the same thread — the TCK flags this as a spec303 violation.Test plan
testngWithJava115 times locally — all pass (190 tests each)CompletionStageMappingOrderedPublisherTckVerificationTestandCompletionStageMappingOrderedPublisherRandomCompleteTckVerificationTest🤖 Generated with Claude Code