Skip to content

Check in field visibility transformer test - union member error now fixed#4275

Merged
dondonz merged 3 commits into
masterfrom
check-in-union-example
Mar 4, 2026
Merged

Check in field visibility transformer test - union member error now fixed#4275
dondonz merged 3 commits into
masterfrom
check-in-union-example

Conversation

@dondonz
Copy link
Copy Markdown
Member

@dondonz dondonz commented Mar 1, 2026

With the large refactor of the field visibility transformer, this issue is now also fixed #4185

For completeness I'm checking in a test with the original bug reported at work, with anonymised schema element names

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 1, 2026 •
edited
Loading

Test Results

  336 files  ±0    336 suites  ±0   5m 12s ⏱️ +2s
5 390 tests +1  5 382 ✅ +1  8 💤 ±0  0 ❌ ±0 
5 479 runs  +1  5 471 ✅ +1  8 💤 ±0  0 ❌ ±0 

Results for commit c48c88c. ± Comparison against base commit 5273839.

This pull request removes 154 and adds 131 tests. Note that renamed tests count towards both. 
	?

	, expected: combo-\"\\\b\f\n\r\t, #4]
                __schema { types { fields { args { type { name fields { name }}}}}}
                __schema { types { fields { type { name fields { name }}}}}
                __schema { types { inputFields { type { inputFields { name }}}}}
                __schema { types { interfaces { fields { type { interfaces { name } } } } } }
                __schema { types { name} }
                __type(name : "t") { name }
                a1: __schema { types { name} }
                a1: __type(name : "t") { name }
…

graphql.ScalarsBooleanTest ‑ parseValue throws exception for invalid input <java.lang.Object@38a5497e>
graphql.ScalarsBooleanTest ‑ serialize throws exception for invalid input <java.lang.Object@7930e73d>
graphql.ScalarsIDTest ‑ parseValue allows any object via String.valueOf <java.lang.Object@367b4c7>
graphql.ScalarsIDTest ‑ serialize allows any object via String.valueOf <java.lang.Object@6c472a75>
graphql.ScalarsIntTest ‑ parseValue throws exception for invalid input <java.lang.Object@2030d990>
graphql.ScalarsIntTest ‑ serialize throws exception for invalid input <java.lang.Object@1b45621b>
graphql.execution.instrumentation.TracingInstrumentationTest ‑ do not trace introspection information [testExecutionStrategy: <graphql.execution.AsyncExecutionStrategy@250870ff fieldCollector=inaccessible executionStepInfoFactory=inaccessible dataFetcherExceptionHandler=inaccessible resolvedType=inaccessible>, #0]
graphql.execution.instrumentation.TracingInstrumentationTest ‑ do not trace introspection information [testExecutionStrategy: <graphql.execution.AsyncSerialExecutionStrategy@72db65cb fieldCollector=inaccessible executionStepInfoFactory=inaccessible dataFetcherExceptionHandler=inaccessible resolvedType=inaccessible>, #1]
graphql.execution.instrumentation.TracingInstrumentationTest ‑ tracing captures timings as expected [testExecutionStrategy: <graphql.execution.AsyncExecutionStrategy@4f284708 fieldCollector=inaccessible executionStepInfoFactory=inaccessible dataFetcherExceptionHandler=inaccessible resolvedType=inaccessible>, #0]
graphql.execution.instrumentation.TracingInstrumentationTest ‑ tracing captures timings as expected [testExecutionStrategy: <graphql.execution.AsyncSerialExecutionStrategy@48ce43e4 fieldCollector=inaccessible executionStepInfoFactory=inaccessible dataFetcherExceptionHandler=inaccessible resolvedType=inaccessible>, #1]
…

♻️ This comment has been updated with latest results.

@dondonz dondonz marked this pull request as draft March 1, 2026 19:35
@dondonz
Copy link
Copy Markdown
Member Author

dondonz commented Mar 1, 2026

Checked out against a copy of the field visibility transformer prior to the fixes (in April 2025) and confirmed the test was failing on the old version.

@dondonz dondonz marked this pull request as ready for review March 1, 2026 20:17
@dondonz dondonz merged commit c8a9d18 into master Mar 4, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andimarek andimarek andimarek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

25.1 bugfix & non-breaking changes

Development

Successfully merging this pull request may close these issues.

FieldVisibilitySchemaTransformation doesn't take union members into account

2 participants

@dondonz @andimarek