Skip to content

Ensure NormalizedQueryTreeFactory handles mutations and subscriptions#2173

Merged
bbakerman merged 4 commits into
graphql-java:masterfrom
austinarbor:fix-gh-2117
Feb 2, 2021
Merged

Ensure NormalizedQueryTreeFactory handles mutations and subscriptions#2173
bbakerman merged 4 commits into
graphql-java:masterfrom
austinarbor:fix-gh-2117

Conversation

@austinarbor
Copy link
Copy Markdown
Contributor

Credit to @skevy for original fix here #2126 but it seems like the PR has stalled on the assertion error

Creating new PR here with suggested assertion changes

Fixes #2117

Comment thread src/main/java/graphql/normalized/NormalizedQueryTreeFactory.java Outdated
@andimarek andimarek added this to the 16.2 milestone Feb 1, 2021
@skevy
Copy link
Copy Markdown

skevy commented Feb 1, 2021

Sorry about the stall. Thank you for picking it up and fixing it!

@bbakerman bbakerman merged commit e93f7ac into graphql-java:master Feb 2, 2021
@austinarbor austinarbor deleted the fix-gh-2117 branch February 3, 2021 05:07
aleksandarsusnjar pushed a commit to aleksandarsusnjar/graphql-java that referenced this pull request May 14, 2021
…graphql-java#2173)

* Ensure NormalizedQueryTreeFactory handles mutations and subscriptions. Credit to @skevy for original fix

* revert wildcard import

* use common method

Co-authored-by: andimarek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DataFetchingEnvironment.getSelectionSet().getFields() is broken from Mutations after upgrade to graphql-java 16

5 participants