The Scalar code is now broken down into their own implementations - #2016
Merged
Merged
Conversation
… easier maintenance
Member
|
Our overall goal is to remove all non standard implementations of Scalars in graphql java and refer people to the scalars addon lib. |
Member
Author
|
Lets deprecate them in this release and do it in another. Unless you want to hard deprecate them now? |
Member
Author
|
I deprecated them for now |
jasonrclark
added a commit
to newrelic/newrelic-graphql-java-core
that referenced
this pull request
Apr 15, 2021
See graphql-java/graphql-java#2016 for more context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This breaks down the monolithic Scalar class into a series of specific classes for each coercing.
This will make it easier to maintain and understand