Sergey/prost bump version to 0 10#3531
Merged
evaporei merged 6 commits intoMay 5, 2022
Merged
Conversation
maoueh
reviewed
May 4, 2022
maoueh
left a comment
maoueh
left a comment
Contributor
There was a problem hiding this comment.
Seems good to me, I enable the CI to see that everything works.
evaporei
approved these changes
May 5, 2022
Contributor
|
Actually, can't you run |
Contributor
Author
|
As an additional step before pushing to git hub? If yes - then yes... it's just anyone who will work with *.proto file will have to remember to do so :-) as generated files will not be formatted. If we really want - earlier tonic-build has this function so we could try to copy it into build.rs... |
…ik-figment/graph-node into sergey/prost_bump_version_to_0_10
lutter
added a commit
that referenced
this pull request
May 6, 2022
Requirement was added in this PR: #3531
lutter
added a commit
that referenced
this pull request
May 6, 2022
Requirement was added in this PR: #3531
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes: