Prohibit subgraphs from using different api_versions#2578
Merged
Conversation
leoyvens
reviewed
Jun 21, 2021
tilacog
force-pushed
the
tiago/add-api-verson-to-ethereum-adapter
branch
6 times, most recently
from
June 23, 2021 14:09
2f000e3 to
b67aa27
Compare
tilacog
commented
Jun 23, 2021
tilacog
commented
Jun 23, 2021
tilacog
commented
Jun 23, 2021
tilacog
commented
Jun 23, 2021
leoyvens
suggested changes
Jun 23, 2021
leoyvens
suggested changes
Jun 28, 2021
tilacog
force-pushed
the
tiago/add-api-verson-to-ethereum-adapter
branch
3 times, most recently
from
June 29, 2021 22:41
b60e35f to
b9781f1
Compare
Also: use ftm::Display instead of ftm::Debug for SubgraphManifestValidationError messages
…ngApiVersion Add a test and a TODO
Also refactored a redundant match arm.
tilacog
commented
Jun 29, 2021
leoyvens
suggested changes
Jun 30, 2021
leoyvens
left a comment
leoyvens
left a comment
Contributor
There was a problem hiding this comment.
Small comments and CI is not passing.
leoyvens
suggested changes
Jul 1, 2021
leoyvens
approved these changes
Jul 1, 2021
leoyvens
left a comment
leoyvens
left a comment
Contributor
There was a problem hiding this comment.
Took a while to perfect this but it's great now, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following:
apiVersionsacross mappingsBlockStreamandTriggerAdapterinstances.