Repository navigation
Adding v1beta1 - #6
danielwhatmuff wants to merge 2 commits into
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Looks reasonable to me - I don't know what the status of these client libraries are though. |
|
Thanks for sending these in though :D Have you tested this and is it working? My leaning is to just merge this and we can normalize the client library situation later. |
Me neither! I noticed there is no |
|
Related - grafeas/grafeas#95 |
|
Last I checked, the protoc tool wasn't able to generate a correct Swagger spec from the protos because the OpenAPI spec isn't rich enough to support the HTTP mappings we use in the protos (https://cloud.google.com/apis/design/standard_methods). @aysylu on the status of this. @danielwhatmuff are you using this Python client library for v1beta1? If you are, and you need it, I'm happy to merge this generated library works for you in its current state. |
|
I was trying to get it working yes but am getting 404s when making calls to the docker image |
|
Is there an alternative image tag I should test against? |
|
I think we have a 0.1.1 version with a bug fixed, but I don't think it's
that bug.
…On Thu, Sep 5, 2019 at 12:10 PM Daniel Whatmuff ***@***.***> wrote:
Is there an alternative image tag I should test against?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6?email_source=notifications&email_token=AHRSOCDC37Y3G4TVH53R55TQIEVQBA5CNFSM4ITQWAJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD57WLUI#issuecomment-528442833>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHRSOCCXUSTX6LQN6V4IXL3QIEVQBANCNFSM4ITQWAJA>
.
|
|
@danielwhatmuff: you'll want to use |
|
@danielwhatmuff: we've moved to using semantic versioning for the server and client lib releases, see versioning doc and client-go. Could you please re-generate this to be |
|
Sure, I will try with the 0.1.0 version. |
|
@danielwhatmuff: thanks! |
|
Closing this due to no activity since Sep 2019. Happy to review another PR for the |
https://raw.githubusercontent.com/grafeas/grafeas/master/proto/v1beta1/swagger/grafeas.swagger.json