Skip to content
This repository was archived by the owner on Apr 19, 2026. It is now read-only.

Adding v1beta1 - #6

Closed
danielwhatmuff wants to merge 2 commits into
grafeas:masterfrom
appvia:master
Closed

danielwhatmuff wants to merge 2 commits into
grafeas:masterfrom
appvia:master

Conversation

@danielwhatmuff

@danielwhatmuff danielwhatmuff commented Sep 4, 2019 •

Copy link
Copy Markdown
  • Generated using https://raw.githubusercontent.com/grafeas/grafeas/master/proto/v1beta1/swagger/grafeas.swagger.json

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@danielwhatmuff

Copy link
Copy Markdown
Author

@googlebot I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@clrprod

clrprod commented Sep 4, 2019

Copy link
Copy Markdown

Looks reasonable to me - I don't know what the status of these client libraries are though.

@clrprod
clrprod requested review from aysylu and vtsao September 4, 2019 16:29
@clrprod

clrprod commented Sep 4, 2019 •

Copy link
Copy Markdown

Thanks for sending these in though :D Have you tested this and is it working? My leaning is to just merge this and we can normalize the client library situation later.

@danielwhatmuff

danielwhatmuff commented Sep 5, 2019 •

Copy link
Copy Markdown
Author

Looks reasonable to me - I don't know what the status of these client libraries are though.

Me neither! I noticed there is no grafeas.swagger.json in the latest grafeas release too... These were generated on the assumption the swagger is accurate but I see a few issues suggesting they might not be. I will test today and let you know the outcome.

@danielwhatmuff

Copy link
Copy Markdown
Author

Related - grafeas/grafeas#95

@vtsao

vtsao commented Sep 5, 2019

Copy link
Copy Markdown

Last I checked, the protoc tool wasn't able to generate a correct Swagger spec from the protos because the OpenAPI spec isn't rich enough to support the HTTP mappings we use in the protos (https://cloud.google.com/apis/design/standard_methods). @aysylu on the status of this.

@danielwhatmuff are you using this Python client library for v1beta1? If you are, and you need it, I'm happy to merge this generated library works for you in its current state.

@danielwhatmuff

Copy link
Copy Markdown
Author

I was trying to get it working yes but am getting 404s when making calls to the docker image grafeas/grafeas:0.1.0 running locally.

@danielwhatmuff

Copy link
Copy Markdown
Author

Is there an alternative image tag I should test against?

@clrprod

clrprod commented Sep 6, 2019 via email

Copy link
Copy Markdown

@danielwhatmuff

Copy link
Copy Markdown
Author

@vtsao @aysylu what are your thoughts on this?

@aysylu

aysylu commented Sep 16, 2019

Copy link
Copy Markdown

@danielwhatmuff: you'll want to use v0.1.0 tag: docker pull us.gcr.io/grafeas/grafeas-server:v0.1.0. Does it work with this tag?

@aysylu

aysylu commented Sep 16, 2019

Copy link
Copy Markdown

@danielwhatmuff: we've moved to using semantic versioning for the server and client lib releases, see versioning doc and client-go. Could you please re-generate this to be 0.1.0 version? Thank you!

@danielwhatmuff

Copy link
Copy Markdown
Author

Sure, I will try with the 0.1.0 version.

@aysylu

aysylu commented Sep 24, 2019

Copy link
Copy Markdown

@danielwhatmuff: thanks!

@aysylu

aysylu commented May 7, 2020

Copy link
Copy Markdown

Closing this due to no activity since Sep 2019. Happy to review another PR for the 0.1.0 version of the client.

@aysylu aysylu closed this May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants