Skip to content

Added clarification about repo re-initialization#1160

Merged
ben merged 2 commits intoprogit:masterfrom
josh-byster:jb/reinitialization
Jan 12, 2019
Merged

Added clarification about repo re-initialization#1160
ben merged 2 commits intoprogit:masterfrom
josh-byster:jb/reinitialization

Conversation

@josh-byster
Copy link
Copy Markdown
Contributor

@josh-byster josh-byster commented Jan 12, 2019

Added a line about running git init even after cloning the repo, as it can be unclear that this command is non-destructive.

Copy link
Copy Markdown
Member

@ben ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you reformat this so each sentence is on its own line? It helps with the diff view for future PRs.

@josh-byster
Copy link
Copy Markdown
Contributor Author

Got it! Just changed. If you want, I can also move the tags to their original line so there's no diff on line 57.

@ben
Copy link
Copy Markdown
Member

ben commented Jan 12, 2019

I think this is fine. The goal of the index tags is to get you to the right page for the thing you're looking for, and I doubt any reasonable typesetting system would break a page between these two sentences. Thanks!

@ben ben merged commit 4486dc8 into progit:master Jan 12, 2019
@josh-byster josh-byster deleted the jb/reinitialization branch January 12, 2019 23:57
@jnavila jnavila added the translation backport Tags a PR for translators to backport in their own repo label Jan 13, 2019
aollier added a commit to aollier/progit2-fr that referenced this pull request Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation backport Tags a PR for translators to backport in their own repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants