Skip to content

feat: Allow to pass requests session #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpoehnelt merged 1 commit into from
Jul 29, 2021
Merged

feat: Allow to pass requests session #414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion googlemaps/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ def __init__(self, key=None, client_id=None, client_secret=None,
retry_timeout=60, requests_kwargs=None,
queries_per_second=50, channel=None,
retry_over_query_limit=True, experience_id=None,
requests_session=None,
base_url=_DEFAULT_BASE_URL):
"""
:param key: Maps API key. Required, unless "client_id" and
Expand Down Expand Up @@ -116,6 +117,9 @@ def __init__(self, key=None, client_id=None, client_secret=None,
implemented. See the official requests docs for more info:
http://docs.python-requests.org/en/latest/api/#main-interface
:type requests_kwargs: dict

:param requests_session: Reused persistent session for flexibility.
:type requests_session: requests.Session

:param base_url: The base URL for all requests. Defaults to the Maps API
server. Should not have a trailing slash.
Expand All @@ -136,7 +140,7 @@ def __init__(self, key=None, client_id=None, client_secret=None,
"and hyphen (-) characters are allowed. If used without "
"client_id, it must be 0-999.")

self.session = requests.Session()
self.session = requests_session or requests.Session()
self.key = key

if timeout and (connect_timeout or read_timeout):
Expand Down