Skip to content

feat: Enforce API key restrictions when used in Android.#740

Merged
arriolac merged 6 commits intomainfrom
auth_provider
Jul 26, 2021
Merged

feat: Enforce API key restrictions when used in Android.#740
arriolac merged 6 commits intomainfrom
auth_provider

Conversation

@arriolac
Copy link
Copy Markdown
Contributor

@arriolac arriolac commented Jul 26, 2021

Summary

Improving security for Android consumers by adding app authentication on the default GeoApiContext so that API key restrictions can be enforced.

Action Items

  • For Android developers, update to the next release that includes this change by updating your build.gradle file. No other change is necessary to your usage.

Fixes #739

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 26, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 26, 2021 •
edited
Loading

Codecov Report

Merging #740 (6240367) into main (8bc0669) will decrease coverage by 1.33%.
The diff coverage is 27.10%.

❗ Current head 6240367 differs from pull request most recent head 1940657. Consider uploading reports for the commit 1940657 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main     #740      +/-   ##
============================================
- Coverage     69.00%   67.67%   -1.34%     
- Complexity      531      541      +10     
============================================
  Files           129      136       +7     
  Lines          2904     3004     +100     
  Branches        283      292       +9     
============================================
+ Hits           2004     2033      +29     
- Misses          748      814      +66     
- Partials        152      157       +5
Impacted Files Coverage Δ
...main/java/com/google/maps/android/PackageInfo.java 0.00% <0.00%> (ø)
...n/java/com/google/maps/android/PackageManager.java 0.00% <0.00%> (ø)
...ain/java/com/google/maps/internal/HttpHeaders.java 0.00% <ø> (ø)
src/main/java/com/google/maps/android/Context.java 6.45% <6.45%> (ø)
...ava/com/google/maps/android/CertificateHelper.java 18.18% <18.18%> (ø)
...ain/java/com/google/maps/OkHttpRequestHandler.java 60.37% <33.33%> (+3.51%) ⬆️
...maps/android/AndroidAuthenticationInterceptor.java 75.00% <75.00%> (ø)
...ogle/maps/android/AndroidAuthenticationConfig.java 100.00% <100.00%> (ø)
...s/android/AndroidAuthenticationConfigProvider.java 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bc0669...1940657. Read the comment docs.

@jpoehnelt jpoehnelt self-requested a review July 26, 2021 21:09
jpoehnelt
jpoehnelt approved these changes Jul 26, 2021
View reviewed changes
Copy link
Copy Markdown

@jpoehnelt jpoehnelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I will likely miss some Java specific issues.

@arriolac arriolac merged commit 9852dba into main Jul 26, 2021
@arriolac arriolac deleted the auth_provider branch July 26, 2021 21:59
googlemaps-bot pushed a commit that referenced this pull request Jul 26, 2021
@semantic-release-bot
chore(release): 0.19.0 [skip ci]
53ff14a 
# [0.19.0](v0.18.2...v0.19.0) (2021-07-26)

### Features

* Enforce API key restrictions when used in Android. ([#740](#740)) ([9852dba](9852dba))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jpoehnelt jpoehnelt jpoehnelt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enforce API key restrictions for Android consumers

3 participants

@arriolac @codecov-commenter @jpoehnelt