Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

feat: support float32 - #531

Merged
olavloite merged 4 commits into
mainfrom
float32
Dec 9, 2024
Merged

feat: support float32#531
olavloite merged 4 commits into
mainfrom
float32

Conversation

@olavloite

@olavloite olavloite commented Dec 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Adds support for FLOAT32 columns. Applications should use the SQLAlchemy type REAL to create a FLOAT32 column, as FLOAT is already reserved for FLOAT64.

Fixes #409

@olavloite
feat: support float32
5071e3d 
Adds support for FLOAT32 columns. Applications should use the SQLAlchemy
type REAL to create a FLOAT32 column, as FLOAT is already reserved for
FLOAT64.

Fixes #409
@olavloite olavloite added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 2, 2024
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Dec 2, 2024
@olavloite
olavloite requested a review from bhatt4982 December 2, 2024 16:32
@olavloite olavloite removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 6, 2024
bhatt4982
bhatt4982 approved these changes Dec 9, 2024
View reviewed changes

@bhatt4982 bhatt4982 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olavloite
olavloite merged commit 6c3cb42 into main Dec 9, 2024
@olavloite
olavloite deleted the float32 branch December 9, 2024 07:44
@release-please release-please Bot mentioned this pull request Dec 6, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@bhatt4982 bhatt4982