Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

fix: connection is always rolled back on returning to a pool - #214

Closed
IlyaFaer wants to merge 1 commit into
mainfrom
connection_rollback
Closed

fix: connection is always rolled back on returning to a pool#214
IlyaFaer wants to merge 1 commit into
mainfrom
connection_rollback

Conversation

@IlyaFaer

@IlyaFaer IlyaFaer commented May 25, 2022

Copy link
Copy Markdown

A decision on this one should be made before merging this PR, otherwise most of the tests will fail.
Fixes: #212

@IlyaFaer IlyaFaer added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label May 25, 2022
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label May 25, 2022
@IlyaFaer
IlyaFaer marked this pull request as ready for review June 1, 2022 10:40
@IlyaFaer

IlyaFaer commented Jun 3, 2022

Copy link
Copy Markdown
Author

Fixed by another PR: #198

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"ValueError: Transaction is already committed" always happens when session.commit()

2 participants