Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

feat: allow SQLAlchemy 1.4 use - #198

Merged
IlyaFaer merged 29 commits into
mainfrom
IlyaFaer-patch-1
Jun 3, 2022
Merged

feat: allow SQLAlchemy 1.4 use#198
IlyaFaer merged 29 commits into
mainfrom
IlyaFaer-patch-1

Conversation

@IlyaFaer

Copy link
Copy Markdown

Allow SQLAlchemy 1.4 to be used with the dialect.

@product-auto-label product-auto-label Bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Jan 27, 2022
@IlyaFaer IlyaFaer changed the title Update setup.py feat: allow SQLAlchemy 1.4 use Jan 27, 2022
@IlyaFaer
IlyaFaer requested review from a team and vi3k6i5 January 28, 2022 08:34
@ansh0l

ansh0l commented Feb 14, 2022

Copy link
Copy Markdown
Contributor

Hi @larkee, I'm adding you as a reviewer, please have a look at if you get some time this week.

@ansh0l
ansh0l requested a review from larkee February 14, 2022 18:19
@ansh0l
ansh0l requested review from asthamohta and removed request for larkee and vi3k6i5 May 14, 2022 19:07

@ansh0l ansh0l left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me, please resolve conflicts, and check with @asthamohta on the merge.

@ansh0l
ansh0l requested review from ansh0l and removed request for ansh0l May 18, 2022 07:58
@ansh0l ansh0l assigned IlyaFaer and unassigned vi3k6i5 May 18, 2022
@IlyaFaer
IlyaFaer force-pushed the IlyaFaer-patch-1 branch from ee5fc65 to 47aa7ee Compare May 19, 2022 13:22
@IlyaFaer

IlyaFaer commented May 20, 2022

Copy link
Copy Markdown
Author

Still trying to fix tests here. I've figured out that if I move a test file to the root folder, it's visible for pytest. But in test folder it always gives 0 collected. So, the problem is somehow related to the folder name/location, it's only left to understand what's exactly wrong.

@asthamohta

Copy link
Copy Markdown
Contributor

Still trying to fix tests here. I've figured out that if I move a test file to the root folder, it's visible for pytest. But in test folder it always gives 0 collected. So, the problem is somehow related to the folder name/location, it's only left to understand what's exactly wrong.

Thanks Ilya for the update

IlyaFaer added 2 commits May 23, 2022 11:20
@IlyaFaer

Copy link
Copy Markdown
Author

@asthamohta, only this bizarre error left with SQLAlchemy 1.3.

I'm thinking what if we'll just drop tests for SQLAlchemy 1.3? Right now new changes for SQLAlchemy 1.3 are pretty rare and they are only about fixing bugs, not functionality. I suspect we have problems here just because 1.3 is not very supported already, so the old test suite wasn't properly updated for the new pytest versions, that's why 1.4 tests are working fine, while 1.3 are not collected (seems like it's happening because of __init__ methods of the test cases). Maybe let's simply drop the 1.3 test session and stick to 1.4? Erasing the double of the test suite for 1.3 should make our life easier.

IlyaFaer added 2 commits June 2, 2022 19:42
@IlyaFaer IlyaFaer closed this Jun 3, 2022
@IlyaFaer IlyaFaer reopened this Jun 3, 2022
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 3, 2022
@IlyaFaer
IlyaFaer merged commit 7793b7d into main Jun 3, 2022
@IlyaFaer
IlyaFaer deleted the IlyaFaer-patch-1 branch June 3, 2022 08:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants