Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

fix: connection reset fails when an additional dialect is used - #188

Merged
IlyaFaer merged 2 commits into
mainfrom
connection_reset
Jan 10, 2022
Merged

fix: connection reset fails when an additional dialect is used#188
IlyaFaer merged 2 commits into
mainfrom
connection_reset

Conversation

@IlyaFaer

@IlyaFaer IlyaFaer commented Jan 7, 2022

Copy link
Copy Markdown

Closes #186

@IlyaFaer IlyaFaer added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Jan 7, 2022
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Jan 7, 2022
@IlyaFaer
IlyaFaer marked this pull request as ready for review January 7, 2022 11:02
@IlyaFaer
IlyaFaer requested a review from vi3k6i5 January 7, 2022 11:03
@ansh0l
ansh0l requested a review from larkee January 7, 2022 11:57
@ansh0l

ansh0l commented Jan 7, 2022

Copy link
Copy Markdown
Contributor

@larkee : Please have a look at this for review.

@ansh0l
ansh0l requested a review from asthamohta January 7, 2022 11:59
Comment thread google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py Outdated
Comment thread google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py Outdated

@vi3k6i5 vi3k6i5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use of python-spanner-alchemy breaks sqlalchemy-sqlite

4 participants