feat: allow SQLAlchemy 1.4 use - #198
Conversation
|
Hi @larkee, I'm adding you as a reviewer, please have a look at if you get some time this week. |
ansh0l
left a comment
There was a problem hiding this comment.
PR looks good to me, please resolve conflicts, and check with @asthamohta on the merge.
ee5fc65 to
47aa7ee
Compare
|
Still trying to fix tests here. I've figured out that if I move a test file to the root folder, it's visible for |
Thanks Ilya for the update |
|
@asthamohta, only this bizarre error left with SQLAlchemy 1.3. I'm thinking what if we'll just drop tests for SQLAlchemy 1.3? Right now new changes for SQLAlchemy 1.3 are pretty rare and they are only about fixing bugs, not functionality. I suspect we have problems here just because 1.3 is not very supported already, so the old test suite wasn't properly updated for the new |
Allow SQLAlchemy 1.4 to be used with the dialect.