This repository was archived by the owner on May 6, 2026. It is now read-only.
feat: Support client_options for Clients - #815
Merged
Merged
Conversation
product-auto-label
Bot
added
the
api: datastore
bw-yuhogg
force-pushed
the
client-options
branch
from
October 18, 2022 17:44
b965368 to
2cd5d4d
Compare
bw-yuhogg
force-pushed
the
client-options
branch
3 times, most recently
from
November 2, 2022 14:52
86f3a2d to
35e82ea
Compare
bw-yuhogg
force-pushed
the
client-options
branch
from
November 3, 2022 20:15
35e82ea to
dd23dd9
Compare
bw-yuhogg
force-pushed
the
client-options
branch
from
November 4, 2022 15:23
dd23dd9 to
be5f517
Compare
bw-yuhogg
changed the title
bw-yuhogg
force-pushed
the
client-options
branch
2 times, most recently
from
November 9, 2022 21:25
949b9c4 to
8516228
Compare
bw-yuhogg
force-pushed
the
client-options
branch
3 times, most recently
from
November 21, 2022 16:32
7907c5e to
13df766
Compare
bw-yuhogg
force-pushed
the
client-options
branch
from
November 30, 2022 19:41
13df766 to
95a7f4d
Compare
bw-yuhogg
changed the title
bw-yuhogg
force-pushed
the
client-options
branch
2 times, most recently
from
December 6, 2022 15:25
02fd8b8 to
947d820
Compare
bw-yuhogg
changed the title
bw-yuhogg
force-pushed
the
client-options
branch
3 times, most recently
from
December 6, 2022 20:31
add8237 to
f0ce2e3
Compare
bw-yuhogg
changed the title
bw-yuhogg
force-pushed
the
client-options
branch
from
December 6, 2022 21:35
f0ce2e3 to
5068705
Compare
bw-yuhogg
changed the title
bw-yuhogg
force-pushed
the
client-options
branch
from
December 9, 2022 14:56
5068705 to
2e3b54e
Compare
parthea
approved these changes
Dec 9, 2022
gcf-owl-bot
Bot
removed
the
owlbot:run
bw-yuhogg
force-pushed
the
client-options
branch
from
December 9, 2022 16:38
2e3b54e to
b085fc0
Compare
Currently, NDB clients do not recognize client_options as a keyword argument. Furthermore, because they currently create a Datastore channel directly, we have to manually modify the host to ensure it is passed to the Datastore channel. Merely setting the API endpoint via environment variable is not sufficient, because that variable's presence is currently used to test whether or not we are using the datastore emulator. Bump api-core dep to ensure we have the necessary API support, also sync it up with google-cloud-datastore.
bw-yuhogg
force-pushed
the
client-options
branch
from
December 12, 2022 17:53
b085fc0 to
f515a93
Compare
Mariatta
approved these changes
Dec 12, 2022
Mariatta
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
This was referenced Sep 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, NDB clients do not recognize
client_optionsas a keyword argument. Furthermore, because they currently create a Datastore channel directly, we have to manually modify the host to ensure it is passed to the Datastore channel. Merely setting the API endpoint via environment variable is not sufficient, because that variable's presence is currently used to test whether or not we are using the datastore emulator.Also, depend directly on the API lib v1.32.0 or later now to ensure that it recognizes
client_options.