Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

feat: add support for python 3.10 - #735

Merged
tseaver merged 7 commits into
mainfrom
add-python-310
Oct 28, 2021
Merged

feat: add support for python 3.10#735
tseaver merged 7 commits into
mainfrom
add-python-310

Conversation

@parthea

@parthea parthea commented Oct 14, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@parthea
parthea requested a review from andrewsg as a code owner October 14, 2021 09:50
@parthea
parthea requested a review from a team October 14, 2021 09:50
@product-auto-label product-auto-label Bot added the api: datastore Issues related to the googleapis/python-ndb API. label Oct 14, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 14, 2021
busunkim96
busunkim96 previously approved these changes Oct 14, 2021
View reviewed changes
@busunkim96
busunkim96 dismissed their stale review October 14, 2021 23:08

NDB owner should review.

@crwilcox

crwilcox commented Oct 15, 2021

Copy link
Copy Markdown
Contributor

Should this also have a change to the noxfile to match so we test against 3.10?

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 15, 2021
@parthea

parthea commented Oct 15, 2021

Copy link
Copy Markdown
Contributor Author

Great catch @crwilcox ! I incorrectly assumed that this repo was using a templated noxfile.

@parthea

parthea commented Oct 16, 2021

Copy link
Copy Markdown
Contributor Author 
Name                                          Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------------------------------------
google/cloud/ndb/__init__.py                    108      0      0      0   100%
google/cloud/ndb/_batch.py                       22      0     10      0   100%
google/cloud/ndb/_cache.py                      300      0     70      0   100%
google/cloud/ndb/_datastore_api.py              395      0    146      0   100%
google/cloud/ndb/_datastore_query.py            456      0    202      2    99%   509->515, 649->655
google/cloud/ndb/_datastore_types.py             29      0     18      0   100%
google/cloud/ndb/_eventloop.py                  141      0     34      0   100%
google/cloud/ndb/_gql.py                        421      0    178      1    99%   365->358
google/cloud/ndb/_legacy_entity_pb.py           596      0    128      0   100%
google/cloud/ndb/_legacy_protocol_buffer.py     149      0     48      2    99%   81->83, 185->180
google/cloud/ndb/_options.py                    114      0     66      0   100%
google/cloud/ndb/_remote.py                      29      0      0      0   100%
google/cloud/ndb/_retry.py                       47      0     21      0   100%
google/cloud/ndb/_transaction.py                152      0     37      3    98%   281->exit, 311->314, 311->exit
google/cloud/ndb/blobstore.py                    74      0      0      0   100%
google/cloud/ndb/client.py                       55      0     10      0   100%
google/cloud/ndb/context.py                     250      0     74      0   100%
google/cloud/ndb/django_middleware.py             5      0      0      0   100%
google/cloud/ndb/exceptions.py                   21      0      0      0   100%
google/cloud/ndb/global_cache.py                269      0    106      0   100%
google/cloud/ndb/key.py                         343      0    142      0   100%
google/cloud/ndb/metadata.py                    116      0     38      0   100%
google/cloud/ndb/model.py                      1811      0    808      0   100%
google/cloud/ndb/msgprop.py                       8      0      0      0   100%
google/cloud/ndb/polymodel.py                    52      0     14      0   100%
google/cloud/ndb/query.py                       735      0    366      0   100%
google/cloud/ndb/stats.py                        85      0      0      0   100%
google/cloud/ndb/tasklets.py                    217      0     74      4    99%   538->542, 546->542, 677->679, 677->exit
google/cloud/ndb/utils.py                        73      0     18      0   100%
tests/unit/__init__.py                            0      0      0      0   100%
tests/unit/models.py                              7      0      0      0   100%
tests/unit/orchestrate.py                       141      0     58      1    99%   268->exit
tests/unit/test__batch.py                        30      0      2      0   100%
tests/unit/test__cache.py                       673      0     14      0   100%
tests/unit/test__datastore_api.py               995      0     30      0   100%
tests/unit/test__datastore_query.py            1047      0     18      0   100%
tests/unit/test__datastore_types.py              56      0      0      0   100%
tests/unit/test__eventloop.py                   278      0      2      0   100%
tests/unit/test__gql.py                         479      0      0      0   100%
tests/unit/test__legacy_entity_pb.py            429      0      0      0   100%
tests/unit/test__options.py                     135      0      2      0   100%
tests/unit/test__remote.py                       63      0      0      0   100%
tests/unit/test__retry.py                       181      0      0      0   100%
tests/unit/test__transaction.py                 437      0      0      0   100%
tests/unit/test_blobstore.py                    107      0      0      0   100%
tests/unit/test_client.py                        94      0      0      0   100%
tests/unit/test_concurrency.py                   13      0      0      0   100%
tests/unit/test_context.py                      418      0      2      0   100%
tests/unit/test_django_middleware.py             10      0      0      0   100%
tests/unit/test_global_cache.py                 464      0      2      0   100%
tests/unit/test_key.py                          743      0     18      0   100%
tests/unit/test_metadata.py                     290      0      0      0   100%
tests/unit/test_model.py                       4619      0     44      0   100%
tests/unit/test_msgprop.py                       15      0      0      0   100%
tests/unit/test_orchestrate.py                  158      0      8      0   100%
tests/unit/test_polymodel.py                     72      0      0      0   100%
tests/unit/test_query.py                       1749      0      2      0   100%
tests/unit/test_stats.py                        298      0      0      0   100%
tests/unit/test_tasklets.py                     577      0     14      0   100%
tests/unit/test_utils.py                         83      0      0      0   100%
tests/unit/utils.py                              21      0      8      0   100%
-----------------------------------------------------------------------------------------
TOTAL                                         21755      0   2832     13    99%
Coverage failure: total of 99 is less than fail-under=100

@tseaver

tseaver commented Oct 18, 2021

Copy link
Copy Markdown
Contributor

@parthea That is a non-sensical result: each of the individual unit-3.x runs show 100%. Not only that, but some of the "uncovered" branches (e.g., the first one, _datastore_query.py ll. 509->515) would also result in other coverage gaps if they were valid (the 509 -> 510 branch is an unconditional raise, which make the entire rest of the function to be uncovered if the other branch were somehow untraversed).

@tseaver

tseaver commented Oct 18, 2021

Copy link
Copy Markdown
Contributor

Might be related to: coveragepy/coveragepy#1223

@tseaver tseaver mentioned this pull request Oct 18, 2021
Closed
@tseaver

tseaver commented Oct 18, 2021

Copy link
Copy Markdown
Contributor

I believe that this is a separate issue. I have reported it here: coveragepy/coveragepy#1249

@parthea

parthea commented Oct 18, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for digging into this @tseaver!

@google-cla

google-cla Bot commented Oct 28, 2021

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 28, 2021
@google-cla

google-cla Bot commented Oct 28, 2021

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@tseaver

tseaver commented Oct 28, 2021

Copy link
Copy Markdown
Contributor

@googlebot I consent.

@google-cla google-cla Bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 28, 2021
@tseaver tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 28, 2021
@tseaver
tseaver merged commit 58620c1 into main Oct 28, 2021
@tseaver
tseaver deleted the add-python-310 branch October 28, 2021 20:10
gcf-merge-on-green Bot pushed a commit that referenced this pull request Oct 28, 2021
@release-please
chore: release 1.11.0 (#739)
4f7f0b4 
🤖 I have created a release \*beep\* \*boop\*
---
## [1.11.0](https://www.github.com/googleapis/python-ndb/compare/v1.10.5...v1.11.0) (2021-10-28)


### Features

* add support for python 3.10 ([#735](https://www.github.com/googleapis/python-ndb/issues/735)) ([58620c1](https://www.github.com/googleapis/python-ndb/commit/58620c1b17e3a4b3608614bea620e93f39e1bd3a))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewsg andrewsg Awaiting requested review from andrewsg
2 more reviewers
@tseaver tseaver tseaver approved these changes
@busunkim96 busunkim96 busunkim96 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@andrewsg andrewsg

Labels

api: datastore Issues related to the googleapis/python-ndb API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@parthea @crwilcox @tseaver @busunkim96 @andrewsg