Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

chore: add codeql-analysis workflow - #163

Closed
freelancing-solutions wants to merge 2 commits into
googleapis:masterfrom
freelancing-solutions:master
Closed

chore: add codeql-analysis workflow#163
freelancing-solutions wants to merge 2 commits into
googleapis:masterfrom
freelancing-solutions:master

Conversation

@freelancing-solutions

Copy link
Copy Markdown

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@freelancing-solutions
freelancing-solutions requested review from a team April 29, 2021 18:38
@product-auto-label product-auto-label Bot added the api: datastore Issues related to the googleapis/python-datastore API. label Apr 29, 2021
@google-cla

google-cla Bot commented Apr 29, 2021

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added the cla: no This human has *not* signed the Contributor License Agreement. label Apr 29, 2021
@google-cla

google-cla Bot commented Apr 29, 2021

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@freelancing-solutions freelancing-solutions changed the title codeql analysis codeql-analysis Apr 29, 2021
@freelancing-solutions freelancing-solutions changed the title codeql-analysis feat: codeql-analysis Apr 29, 2021
@freelancing-solutions

Copy link
Copy Markdown
Author

@googlebot I signed it!

@google-cla google-cla Bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 29, 2021
@freelancing-solutions

Copy link
Copy Markdown
Author

Added codeql security analysis github workflow to the repository.

@tseaver

tseaver commented May 3, 2021

Copy link
Copy Markdown
Contributor

@freelancing-solutions Thanks for the patch! We are discussing the implications of adding CodeQL to this repository (and likely others). I'm not personally familiar with the tool: can you describe your motivation for wanting to add it?

@tseaver tseaver changed the title feat: codeql-analysis chore: add codeql-analysis workflow May 3, 2021
@tseaver

tseaver commented May 3, 2021

Copy link
Copy Markdown
Contributor

@freelancing-solutions Again, thank you for the patch, and for bringing the CodeQL tool to our attention. For such process-related / CI chores, the team prefers to discuss them and then add them broadly, across most / all the googleapis repos, using the autosynth tools we have built.

@tseaver tseaver closed this May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastore Issues related to the googleapis/python-datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants