Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

doc: share design document for query retry logic - #1123

Merged
steffnay merged 5 commits into
mainfrom
query-retries-design
Jun 27, 2022
Merged

doc: share design document for query retry logic#1123
steffnay merged 5 commits into
mainfrom
query-retries-design

Conversation

@tswast

@tswast tswast commented Jan 28, 2022

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal support ticket 29904196 🦕

@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jan 28, 2022
@tswast tswast closed this Mar 30, 2022
@tswast

tswast commented Jun 22, 2022

Copy link
Copy Markdown
Contributor Author

Reopening, as another large customer is also interested in this documentation.

We may want to add some "known issues" linking to general job retries. googleapis/google-cloud-python#15738

@tswast tswast reopened this Jun 22, 2022
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Jun 22, 2022
@tswast
tswast marked this pull request as ready for review June 22, 2022 21:27
@tswast
tswast requested review from a team and steffnay June 22, 2022 21:27
@dandhlee dandhlee self-assigned this Jun 24, 2022

@dandhlee dandhlee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor nit.

Comment thread docs/design/query-retries.md Outdated
@steffnay
steffnay merged commit 2cc4c0b into main Jun 27, 2022
@steffnay
steffnay deleted the query-retries-design branch June 27, 2022 19:39
waltaskew pushed a commit to waltaskew/python-bigquery that referenced this pull request Jul 20, 2022
* doc: share design document for query retry logic

* add design document to contents tree

* clarify a few points

* Update docs/design/query-retries.md

Co-authored-by: Dan Lee <[email protected]>

Co-authored-by: Dan Lee <[email protected]>
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
* doc: share design document for query retry logic

* add design document to contents tree

* clarify a few points

* Update docs/design/query-retries.md

Co-authored-by: Dan Lee <[email protected]>

Co-authored-by: Dan Lee <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants