This repository was archived by the owner on Mar 17, 2026. It is now read-only.
filter topics by short names#16
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 8 8
Lines 830 830
=====================================
Hits 830 830Continue to review full report at Codecov.
|
feywind
pushed a commit
to feywind/nodejs-pubsub
that referenced
this pull request
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #5
We've been seeing consistent failures of
getTopics()system-tests on CircleCI. After digging in, I believe the issue is that we are are half-initializing several Topic objects and comparing the names of said objects against the names returned from the API.Why is that an issue? Well unless a project id environment variable is set, we use a placeholder
{{projectId}}that could cause the comparison to fail, which would explain the failing tests. This will instead compare the short names which should be unique ids.