Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

chore: prep release for 0.18.0#112

Merged
callmehiphop merged 2 commits into
googleapis:masterfrom
callmehiphop:0.18.0
Mar 29, 2018
Merged

chore: prep release for 0.18.0#112
callmehiphop merged 2 commits into
googleapis:masterfrom
callmehiphop:0.18.0

Conversation

@callmehiphop
Copy link
Copy Markdown
Contributor

@callmehiphop callmehiphop commented Mar 28, 2018

Features

Fixes

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 28, 2018

Codecov Report

Merging #112 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #112   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines         867    867           
=====================================
  Hits          867    867

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76cb329...7aa5c9e. Read the comment docs.

@stephenplusplus
Copy link
Copy Markdown
Contributor

Made some small changes to the notes.

  • Move Features above Fixes to document in same priority of semver
  • Remove docs-related fixes. The reader of the release notes probably most cares about code stuff
  • Re-worded "gax configuration" to "API request parameters", as well as a little more from that line. gaxOpts as an option name throughout the API doesn't hide "gax", so that the user can differentiate between the options we take and what comes from "gax" (a term they likely haven't heard before, but are linked to in the docs to go learn about). In the case of release notes, they should sell what the feature is, so I just dumbed down the lingo, and said what it really is.

Here are the originals, if you think I went too far on any of those points!:

Fixes

Features

@callmehiphop callmehiphop merged commit 8d9016f into googleapis:master Mar 29, 2018
stephenplusplus pushed a commit to stephenplusplus/nodejs-pubsub that referenced this pull request Aug 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants