Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

Fix publish exmaple, which was handling the response as though it mad…#108

Merged
callmehiphop merged 2 commits into
googleapis:masterfrom
kamalaboulhosn:master
Mar 28, 2018
Merged

Fix publish exmaple, which was handling the response as though it mad…#108
callmehiphop merged 2 commits into
googleapis:masterfrom
kamalaboulhosn:master

Conversation

@kamalaboulhosn
Copy link
Copy Markdown
Contributor

@kamalaboulhosn kamalaboulhosn commented Mar 26, 2018

…e the raw underlying publish call instead of the client library call.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@kamalaboulhosn
Fix publish exmaple, which was handling the response as though it mad…
930f749 
…e the raw underlying publish call instead of the client library call.
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2018 •
edited
Loading

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #108   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines         869    869           
=====================================
  Hits          869    869

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0840b04...6e01aed. Read the comment docs.

@googlebot
Copy link
Copy Markdown

googlebot commented Mar 28, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@callmehiphop callmehiphop merged commit 09a7f1b into googleapis:master Mar 28, 2018
@callmehiphop
Copy link
Copy Markdown
Contributor

callmehiphop commented Mar 28, 2018

Thanks for the fix @kamalaboulhosn

@callmehiphop callmehiphop mentioned this pull request Mar 28, 2018
Merged
stephenplusplus pushed a commit to stephenplusplus/nodejs-pubsub that referenced this pull request Aug 31, 2018
@renovate @JustinBeckwith
chore(deps): lock file maintenance (googleapis#108)
2aacc60
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
@kolodny
Add basic CRUDL operations for App Profiles. (googleapis#124)
c2ce475 
Fixes googleapis#108

- [x] Tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@callmehiphop callmehiphop callmehiphop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kamalaboulhosn @googlebot @callmehiphop