Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

change maxMessages default to 100#107

Merged
callmehiphop merged 5 commits into
googleapis:masterfrom
callmehiphop:dg--2810
Mar 28, 2018
Merged

change maxMessages default to 100#107
callmehiphop merged 5 commits into
googleapis:masterfrom
callmehiphop:dg--2810

Conversation

@callmehiphop
Copy link
Copy Markdown
Contributor

@callmehiphop callmehiphop commented Mar 26, 2018

Relates to googleapis/google-cloud-node#2810

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@callmehiphop
Copy link
Copy Markdown
Contributor Author

/cc @jadekler @kir-titievsky

@jeanbza
Copy link
Copy Markdown

jeanbza commented Mar 26, 2018

👍 Might be worth updating documentation to recommend folks tune this variable per their needs

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2018

Codecov Report

Merging #107 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #107   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines         869    869           
=====================================
  Hits          869    869
Impacted Files Coverage Δ
src/subscription.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09a7f1b...68912ac. Read the comment docs.

@callmehiphop callmehiphop merged commit 456139c into googleapis:master Mar 28, 2018
@jeanbza
Copy link
Copy Markdown

jeanbza commented Mar 28, 2018

Thanks @callmehiphop . Do you know when this will be released in a version I can try?

@stephenplusplus
Copy link
Copy Markdown
Contributor

You can track the release in #112. If you're just looking to try it out, you can try right from master:

$ npm install --save googleapis/nodejs-pubsub

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants