This repository was archived by the owner on Aug 13, 2026. It is now read-only.
test: presubmit against Lite samples - #713
Merged
Merged
Conversation
product-auto-label
Bot
added
api: pubsub
google-cla
Bot
added
the
cla: yes
|
Warning: This pull request is touching the following templated files:
|
anguillanneuf
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
anguillanneuf
marked this pull request as ready for review
June 14, 2021 18:20
hannahrogers-google
approved these changes
Jun 14, 2021
anguillanneuf
force-pushed
the
lite-samples-testing
branch
3 times, most recently
from
June 14, 2021 19:56
3562611 to
72543c8
Compare
kolea2
reviewed
Jun 14, 2021
anguillanneuf
force-pushed
the
lite-samples-testing
branch
2 times, most recently
from
June 14, 2021 20:38
21983ef to
b70fa65
Compare
anguillanneuf
force-pushed
the
lite-samples-testing
branch
from
June 14, 2021 20:56
b70fa65 to
1869786
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a presubmit test to run against samples in https://github.com/googleapis/java-pubsublite.
This is to prevent future development here from breaking
java-pubsubliteunknowingly, which has happened before forpython-pubsub==2.4.0. See https://pypi.org/project/google-cloud-pubsub/#historyNeed to wait forinternal cl/378963191to merge first.submitted.This samples tests should correctly use the local/snapshot artifact instead of the remote one because
mvn clean installruns before any samples tests."Downloading in Maven is triggered by a project declaring a dependency that is not present in the local repository": https://maven.apache.org/guides/introduction/introduction-to-repositories.html#downloading-from-a-remote-repository