Conversation
…. updated Connection.create_table() to pass column families dict to low_level_table. 4. Updated unit tests.
googlebot
added
the
cla: yes
|
System tests still failing on python 3.x, working fine with python 2.x. I forgot to run system tests on py3.x. |
|
@tseaver made changes to make system-tests running with py3.x. Most of the changes are related to str to bytes conversion. |
|
@googleapis/yoshi-python, can someone please review this? |
|
@tseaver Can you please review this PR. |
|
@googleapis/yoshi-python, can we please get a review? |
tseaver
left a comment
tseaver
left a comment
There was a problem hiding this comment.
As a user, I would be surprised / upset to pass row data with text keys into the library, and get the same data back, except with bytes keys. If we are going to be returning row data with bytes keys, we need to document that fact somewhere.
unit_tests/test_table.py
Outdated
| qual = 'qual' | ||
| fake_cells = object() | ||
| partial_row._cells = {col_fam: {qual: fake_cells}} | ||
| partial_row._cells = {col_fam: {qual.encode(): fake_cells}} |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@sumit-ql, it looks like there are some follow up comments |
4 participants
This also partially fix the issue #45