feat(datastore): add return query object in add filter method - #9892
Closed
HemangChothani wants to merge 1 commit into
Closed
feat(datastore): add return query object in add filter method#9892HemangChothani wants to merge 1 commit into
HemangChothani wants to merge 1 commit into
Conversation
HemangChothani
requested review from
crwilcox,
frankyn and
tseaver
as code owners
November 26, 2019 05:24
googlebot
added
the
cla: yes
BenWhitehead
reviewed
Jan 9, 2020
BenWhitehead
left a comment
BenWhitehead
left a comment
Contributor
There was a problem hiding this comment.
Conceptually this seems okay to me, but I'll defer to my more python knowledgeable colleagues to determine if this is a safe API change.
Contributor
Author
|
Closing this PR as suppressed by 12 in new repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9876