fix: resolve collision with reserved words in samples - #17912
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the GAPIC generator to use the client method name instead of the raw RPC name when generating sample method names. This ensures that Python-specific method name overrides (such as appending an underscore to reserved keywords like import) are correctly reflected in the generated samples. A new Import RPC and its corresponding golden test files have been added to verify this behavior. I have no feedback to provide as there are no review comments.
44f7403 to
973dd75
Compare
973dd75 to
98c5ddb
Compare
98c5ddb to
a68ec1c
Compare
|
Here is the summary of possible violations 😱 DetailsThere are 2 possible violations for not having product prefix.
The end of the violation section. All the stuff below is FYI purposes only. Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
3 participants
Towards b/537730936