fix: require Python 3.10+#17245
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the google-cloud-bigtable library, bumping the minimum supported Python version to 3.10 and updating core dependencies. It introduces internal session-related types, adds an Edition field to the Instance type, and enhances AutomatedBackupPolicy with location-based settings. The PR also includes significant cleanup of repository metadata, fixes to asynchronous sample code, and updates to the documentation and copyright headers. I have no feedback to provide.
parthea
changed the title
|
This file has a lingering reference to 3.8 that is unnecessary: Other than that, this looks very clean of all references to 3.7, 3.8, 3.9. Lingering references appear to be standard boilerplate that should be there. |
chalmerlowe
left a comment
chalmerlowe
left a comment
There was a problem hiding this comment.
I would like to request that one last unnecessary reference to version 3.8 be removed.
Other than that, approved.
|
New failures |
chalmerlowe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
Gonna close temporarily to trigger a re-evaluation of merge against |
|
Due to our settings, this PR is not automagically comparing against
You should be able to confirm by:
That should ensure that your branch has the If you have any troubles, please let me know. |
|
Wait for googleapis/librarian#6171 |
…essages (#17273) This PR resolves the following failure in #17245 ([build log](https://github.com/googleapis/google-cloud-python/actions/runs/26527262176/job/78134171625?pr=17245)) ``` ==================================== ERRORS ==================================== _ ERROR collecting tests/unit/gapic/bigtable_admin_v2/test_bigtable_instance_admin.py _ tests/unit/gapic/bigtable_admin_v2/test_bigtable_instance_admin.py:7259: in <module> iam_policy_pb2.GetIamPolicyRequest({}), ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ E TypeError: _AddInitMethod.<locals>.init() takes 1 positional argument but 2 were given _ ERROR collecting tests/unit/gapic/bigtable_admin_v2/test_bigtable_table_admin.py _ tests/unit/gapic/bigtable_admin_v2/test_bigtable_table_admin.py:11222: in <module> iam_policy_pb2.GetIamPolicyRequest({}), ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ E TypeError: _AddInitMethod.<locals>.init() takes 1 positional argument but 2 were given ``` To resolve the issue, this PR adds `**` to unpack fields as keyword arguments, maintaining compatibility with both proto-plus and pure protobuf messages.
🤖 I have created a release *beep* *boop* --- ## [2.39.0](google-cloud-bigtable-v2.38.0...google-cloud-bigtable-v2.39.0) (2026-06-22) ### Features * added client side metric instrumentation to read_rows and mutate_rows ([#16758](#16758)) ([4005e66](4005e66)) * **bigtable:** add client side metric instrumentation to basic rpcs ([#16712](#16712)) ([636af26](636af26)) * **bigtable:** add view_parameters support to execute_query ([#17382](#17382)) ([2695aad](2695aad)) * support row_range in sample_row_keys method ([#17330](#17330)) ([384724c](384724c)), closes [#17329](#17329) * update API sources and regenerate ([#17431](#17431)) ([2e75c78](2e75c78)) * update googleapis and regenerate ([33ba3af](33ba3af)) ### Bug Fixes * **bigtable:** ensure deadline is respected for read_rows_sharded ([#17352](#17352)) ([6cc890b](6cc890b)) * require Python 3.10+ ([#17245](#17245)) ([200b0d3](200b0d3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
4 participants
chore: enable generation / release for bigtable
Fixes b/510022189, b/507893758, b/507889482, b/503326310