feat: add more types to google.cloud.firestore.BaseDocumentReference - #16503
Open
tharvik wants to merge 5 commits into
Open
feat: add more types to google.cloud.firestore.BaseDocumentReference#16503tharvik wants to merge 5 commits into
google.cloud.firestore.BaseDocumentReference#16503tharvik wants to merge 5 commits into
Conversation
tharvik
changed the title
google.cloud.firestore.BaseDocumentReferencegoogle.cloud.firestore.BaseDocumentReference
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements comprehensive type hinting for Firestore document references, making BaseDocumentReference generic to support both sync and async clients and adding explicit None checks for the client across various methods. Review feedback suggests refining these checks by moving them before path access to prevent AttributeError, using more descriptive error messages for retrieval operations, and adopting more idiomatic Python patterns such as using tuples for hashing and programmatically sorting dictionary keys.
Author
|
well, anything I can do to move things along? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16502 🦕
also:
BaseDocumentReference.clientis used w/o checking for None