feat(firestore): add BSONMinKey and BSONMaxKey support - #18385
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the BSONMinKey and BSONMaxKey classes to the google-cloud-firestore package, representing BSON MinKey and MaxKey sentinel values for query range boundaries. These classes are exposed in the package's public interface and include serialization, representation, equality, hashing, copying, and pickling capabilities. Additionally, comprehensive unit and system tests (both synchronous and asynchronous) have been added to verify their behavior. There are no review comments provided, so no further feedback is necessary.
ohmayr
marked this pull request as ready for review
September 15, 2026 23:39
ohmayr
added this pull request to stack #18386
September 15, 2026 23:51
ohmayr
force-pushed
the
bson-pr1b-minkey-maxkey
branch
from
September 16, 2026 00:10
ed57926 to
8ce8b10
Compare
ohmayr
force-pushed
the
bson-pr1b-minkey-maxkey
branch
from
September 16, 2026 00:21
8ce8b10 to
173e2e0
Compare
ohmayr
force-pushed
the
bson-pr1b-minkey-maxkey
branch
2 times, most recently
from
September 16, 2026 01:57
b10b328 to
173e2e0
Compare
ohmayr
force-pushed
the
bson-pr1b-minkey-maxkey
branch
from
September 16, 2026 02:01
173e2e0 to
c583e2e
Compare
ohmayr
force-pushed
the
bson-pr1b-minkey-maxkey
branch
from
September 16, 2026 02:08
c583e2e to
edd355d
Compare
ohmayr
force-pushed
the
bson-pr1b-minkey-maxkey
branch
from
September 16, 2026 07:43
edd355d to
8a5c3ba
Compare
Merged
zhumin8
pushed a commit
that referenced
this pull request
Sep 17, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>google-ads-admanager: 0.10.5</summary> ## [0.10.5](google-ads-admanager-v0.10.4...google-ads-admanager-v0.10.5) (2026-09-17) ### Features * update API sources and regenerate ([#18396](#18396)) ([e9f8e59](e9f8e59)) * update API sources and regenerate. ([e9f8e59](e9f8e59)) </details> <details><summary>google-ads-datamanager: 0.9.3</summary> ## [0.9.3](google-ads-datamanager-v0.9.2...google-ads-datamanager-v0.9.3) (2026-09-17) ### Features * update API sources and regenerate ([#18396](#18396)) ([e9f8e59](e9f8e59)) * update API sources and regenerate. ([e9f8e59](e9f8e59)) </details> <details><summary>google-analytics-data: 0.23.1</summary> ## [0.23.1](google-analytics-data-v0.23.0...google-analytics-data-v0.23.1) (2026-09-17) ### Features * update API sources and regenerate ([#18396](#18396)) ([e9f8e59](e9f8e59)) * update API sources and regenerate. ([e9f8e59](e9f8e59)) </details> <details><summary>google-api-core: 2.38.0</summary> ## [2.38.0](google-api-core-v2.37.0...google-api-core-v2.38.0) (2026-09-17) ### Features * **core:** add request hook to enrich T4 network spans with GCP resource attributes (E) ([#18272](#18272)) ([1ca95e9](1ca95e9)) </details> <details><summary>google-apps-meet: 0.5.1</summary> ## [0.5.1](google-apps-meet-v0.5.0...google-apps-meet-v0.5.1) (2026-09-17) ### Features * update API sources and regenerate ([#18396](#18396)) ([e9f8e59](e9f8e59)) * update API sources and regenerate. ([e9f8e59](e9f8e59)) </details> <details><summary>google-cloud-api-gateway: 1.17.0</summary> ## [1.17.0](google-cloud-api-gateway-v1.16.0...google-cloud-api-gateway-v1.17.0) (2026-09-17) ### Features * update API sources and regenerate ([#18396](#18396)) ([e9f8e59](e9f8e59)) * update API sources and regenerate. ([e9f8e59](e9f8e59)) </details> <details><summary>google-cloud-auditmanager: 0.3.2</summary> ## [0.3.2](google-cloud-auditmanager-v0.3.1...google-cloud-auditmanager-v0.3.2) (2026-09-17) ### Features * update API sources and regenerate ([#18396](#18396)) ([e9f8e59](e9f8e59)) * update API sources and regenerate. ([e9f8e59](e9f8e59)) </details> <details><summary>google-cloud-backupdr: 0.10.2</summary> ## [0.10.2](google-cloud-backupdr-v0.10.1...google-cloud-backupdr-v0.10.2) (2026-09-17) ### Features * **google/cloud/backupdr/v1beta:** add google-cloud-backupdr ([#18399](#18399)) ([91b7ae7](91b7ae7)) </details> <details><summary>google-cloud-bigquery: 3.45.2</summary> ## [3.45.2](google-cloud-bigquery-v3.45.1...google-cloud-bigquery-v3.45.2) (2026-09-17) ### Bug Fixes * disambiguate google-cloud-bigquery `to_dataframe` usage from `pandas-gbq` in ua. ([#18369](#18369)) ([0d7d59c](0d7d59c)) </details> <details><summary>google-cloud-bigtable: 2.46.0</summary> ## [2.46.0](google-cloud-bigtable-v2.45.0...google-cloud-bigtable-v2.46.0) (2026-09-17) ### Features * **bigtable:** Rerouted RowSet and RowRange to use ReadRows from data client ([#18196](#18196)) ([1857302](1857302)) * Rerouted ReadRows to data client ([#18198](#18198)) ([934cd2d](934cd2d)) * update API sources and regenerate ([#18396](#18396)) ([e9f8e59](e9f8e59)) * update API sources and regenerate. ([e9f8e59](e9f8e59)) ### Bug Fixes * **bigtable:** Added rst_stream exception handling for ReadRows. ([#18197](#18197)) ([f30df60](f30df60)) </details> <details><summary>google-cloud-compute: 1.54.0</summary> ## [1.54.0](google-cloud-compute-v1.53.0...google-cloud-compute-v1.54.0) (2026-09-17) ### Features * update API sources and regenerate ([#18396](#18396)) ([e9f8e59](e9f8e59)) * update API sources and regenerate. ([e9f8e59](e9f8e59)) </details> <details><summary>google-cloud-compute-v1beta: 0.12.6</summary> ## [0.12.6](google-cloud-compute-v1beta-v0.12.5...google-cloud-compute-v1beta-v0.12.6) (2026-09-17) ### Features * update API sources and regenerate ([#18396](#18396)) ([e9f8e59](e9f8e59)) * update API sources and regenerate. ([e9f8e59](e9f8e59)) </details> <details><summary>google-cloud-devicestreaming: 0.5.1</summary> ## [0.5.1](google-cloud-devicestreaming-v0.5.0...google-cloud-devicestreaming-v0.5.1) (2026-09-17) ### Features * update API sources and regenerate ([#18396](#18396)) ([e9f8e59](e9f8e59)) * update API sources and regenerate. ([e9f8e59](e9f8e59)) </details> <details><summary>google-cloud-discoveryengine: 0.20.4</summary> ## [0.20.4](google-cloud-discoveryengine-v0.20.3...google-cloud-discoveryengine-v0.20.4) (2026-09-17) ### Features * update API sources and regenerate ([#18396](#18396)) ([e9f8e59](e9f8e59)) * update API sources and regenerate. ([e9f8e59](e9f8e59)) </details> <details><summary>google-cloud-firestore: 2.31.0</summary> ## [2.31.0](google-cloud-firestore-v2.30.0...google-cloud-firestore-v2.31.0) (2026-09-17) ### Features * **firestore:** add BSONInt32 support ([#18388](#18388)) ([136d4b9](136d4b9)) * **firestore:** add BSONMinKey and BSONMaxKey support ([#18385](#18385)) ([9a1fb24](9a1fb24)) </details> <details><summary>google-cloud-kms: 3.17.0</summary> ## [3.17.0](google-cloud-kms-v3.16.0...google-cloud-kms-v3.17.0) (2026-09-17) ### Features * update API sources and regenerate ([#18396](#18396)) ([e9f8e59](e9f8e59)) * update API sources and regenerate. ([e9f8e59](e9f8e59)) </details> <details><summary>google-cloud-network-services: 0.10.3</summary> ## [0.10.3](google-cloud-network-services-v0.10.2...google-cloud-network-services-v0.10.3) (2026-09-17) ### Features * **google/cloud/networkservices/v1beta1:** add google-cloud-network-services ([#18398](#18398)) ([8df34ce](8df34ce)) ### Bug Fixes * empty commit to bump v1beta version ([#18411](#18411)) ([3b3cc6f](3b3cc6f)) </details> <details><summary>google-cloud-pubsub: 2.41.0</summary> ## [2.41.0](google-cloud-pubsub-v2.40.0...google-cloud-pubsub-v2.41.0) (2026-09-17) ### Features * update API sources and regenerate ([#18396](#18396)) ([e9f8e59](e9f8e59)) * update API sources and regenerate. ([e9f8e59](e9f8e59)) </details> <details><summary>google-cloud-securesourcemanager: 0.6.2</summary> ## [0.6.2](google-cloud-securesourcemanager-v0.6.1...google-cloud-securesourcemanager-v0.6.2) (2026-09-17) ### Features * update API sources and regenerate ([#18396](#18396)) ([e9f8e59](e9f8e59)) * update API sources and regenerate. ([e9f8e59](e9f8e59)) </details> <details><summary>google-maps-solar: 0.6.1</summary> ## [0.6.1](google-maps-solar-v0.6.0...google-maps-solar-v0.6.1) (2026-09-17) ### Features * update API sources and regenerate ([#18396](#18396)) ([e9f8e59](e9f8e59)) * update API sources and regenerate. ([e9f8e59](e9f8e59)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds write support for BSON
MinKeyandMaxKeyquery range boundary sentinels in Cloud Firestore Enterprise databases.BSONMinKey: Sentinel representing the lowest possible value in BSON sort order, serializing to{"__min__": None}.BSONMaxKey: Sentinel representing the highest possible value in BSON sort order, serializing to{"__max__": None}.Fixes b/562164019 🦕