feat(tools): add --no-comments support to compileProtos to reduce proto file size#8890
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a '--no-comments' flag to the 'compileProtos' tool, allowing users to strip comments from generated JavaScript files using 'uglify-js'. The review feedback highlights that the current implementation lacks error handling for the minification process and suggests refactoring the duplicated 'uglify-js' options. Additionally, the reviewer requested a new test case to verify the functionality of the '--no-comments' flag.
quirogas
marked this pull request as ready for review
July 16, 2026 19:47
feywind
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
--no-commentsincompileProtosto reduce the file size of proto.js files.When
--no-commentsis passed,compileProtosfirst runspbjswith comments so thatpbtscan construct the complete TypeScript type definitions inprotos.d.ts. Afterward, comments and whitespace inprotos.js(andprotos.cjs) are stripped usinguglify-js.This addresses file size limits on large proto packages (e.g.,
google-cloud-computeexceeding GitHub's 100MB file limit). Stripping comments reducesprotos.jsfile size by ~82% while keeping TypeScript types and runtime interfaces fully backwards compatibleFor #8889
For googleapis/librarian#6638