Skip to content

spanner-jdbc: Step 01 - Create jdbc project - #5805

Merged
olavloite merged 2 commits into
googleapis:spanner-jdbcfrom
olavloite:spanner-jdbc-01-create-project
Jul 23, 2019
Merged

spanner-jdbc: Step 01 - Create jdbc project#5805
olavloite merged 2 commits into
googleapis:spanner-jdbcfrom
olavloite:spanner-jdbc-01-create-project

Conversation

@olavloite

@olavloite olavloite commented Jul 23, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Step 1: Create the project folder, pom and readme for the open source JDBC driver.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2019
@olavloite olavloite changed the title spanner-jdbc: Step 1 - Create jdbc project spanner-jdbc: Step 01 - Create jdbc project Jul 23, 2019
@olavloite
olavloite marked this pull request as ready for review July 23, 2019 11:48
@olavloite
olavloite requested a review from kolea2 July 23, 2019 11:49
kolea2
kolea2 suggested changes Jul 23, 2019
View reviewed changes

@kolea2 kolea2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please also add to versions.txt (this will automatically increment the version number on releases).

@kolea2 kolea2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 23, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 23, 2019
@codecov

codecov Bot commented Jul 23, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #5805 into spanner-jdbc will decrease coverage by 0.67%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##             spanner-jdbc    #5805      +/-   ##
==================================================
- Coverage           46.79%   46.11%   -0.68%     
+ Complexity          25648    24187    -1461     
==================================================
  Files                2456     2456              
  Lines              267593   262236    -5357     
  Branches            30564    29602     -962     
==================================================
- Hits               125228   120943    -4285     
+ Misses             133106   132179     -927     
+ Partials             9259     9114     -145
Impacted Files Coverage Δ Complexity Δ
.../java/com/google/cloud/testing/CommandWrapper.java 87.87% <0%> (-9.1%) 13% <0%> (ø)
.../cloud/datastore/testing/LocalDatastoreHelper.java 80.59% <0%> (-4.48%) 17% <0%> (ø)
...in/java/com/google/cloud/storage/StorageBatch.java 88% <0%> (-4%) 13% <0%> (ø)
...m/google/cloud/vision/v1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...age/contrib/nio/SeekableByteChannelPrefetcher.java 63.12% <0%> (-3.13%) 21% <0%> (-2%)
...gle/cloud/storage/testing/RemoteStorageHelper.java 61.98% <0%> (-3.06%) 9% <0%> (ø)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
.../java/com/google/cloud/speech/v1/SpeechClient.java 48.57% <0%> (-2.78%) 10% <0%> (-2%)
... and 654 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b56711...0e33c22. Read the comment docs.

@olavloite

olavloite commented Jul 23, 2019

Copy link
Copy Markdown
Contributor Author

LGTM but please also add to versions.txt (this will automatically increment the version number on releases).

Added to versions.txt.

kolea2
kolea2 reviewed Jul 23, 2019
View reviewed changes
Comment thread google-cloud-clients/google-cloud-contrib/google-cloud-spanner-jdbc/README.md
@@ -0,0 +1,124 @@
#JDBC driver for Google Cloud Spanner

@kolea2 kolea2 Jul 23, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing this - you can address this in the next commit, but this needs a space between the # and JDBC. Also, please capitalize Driver

@olavloite olavloite Jul 23, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, NP.

@olavloite
olavloite merged commit cafacf1 into googleapis:spanner-jdbc Jul 23, 2019
olavloite added a commit to olavloite/google-cloud-java that referenced this pull request Aug 5, 2019
@olavloite
spanner-jdbc: Step 01 - Create jdbc project (googleapis#5805)
1f4dacd 
* create jdbc project

* added spanner-jdbc to versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@kolea2 kolea2 kolea2 requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@olavloite @kolea2 @googlebot @yoshi-kokoro