Skip to content

bind enforcement to validate phase#3193

Closed
elharo wants to merge 8 commits intogoogleapis:masterfrom
elharo:master
Closed

bind enforcement to validate phase#3193
elharo wants to merge 8 commits intogoogleapis:masterfrom
elharo:master

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Apr 25, 2018

Fails locally:

[ERROR] Failed to execute goal on project google-cloud-core-grpc: Could not resolve dependencies for project com.google.cloud:google-cloud-core-grpc:jar:1.27.1-SNAPSHOT: Could not find artifact com.google.cloud:google-cloud-core:jar:1.27.1-SNAPSHOT -> [Help 1]
[ERROR]

@elharo elharo requested a review from pongad as a code owner April 25, 2018 20:21
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 25, 2018
pom.xml Outdated
</requireJavaVersion>
<dependencyConvergence/>
<dependencyConvergence>
</dependencyConvergence>

This comment was marked as spam.

This comment was marked as spam.

Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this passed CI, by the way. I was expecting it to fail. There's clearly still more going on here than I understand yet.

@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2018
@sduskis
Copy link
Contributor

sduskis commented Nov 1, 2018

@elharo, do you mind resolving the conflicts?

@elharo elharo requested a review from a team November 1, 2018 12:51
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2018
@elharo
Copy link
Contributor Author

elharo commented Nov 1, 2018

Tried to merge, but please check carefully. A lot more came in than I expected.

@sduskis
Copy link
Contributor

sduskis commented Nov 1, 2018

@garrettjonesgoogle and @chingor13, do either of you have any objections to this PR?

pom.xml Outdated
<excludes>
<exclude>**/*SmokeTest.java</exclude>
<exclude>**/IT*.java</exclude>
<exclude>**/*SmokeTest.java</exclude>

This comment was marked as spam.

<version>[1.7,)</version>
</requireJavaVersion>
<dependencyConvergence />
<requireUpperBoundDeps/>

This comment was marked as spam.

pom.xml Outdated
<requireJavaVersion>
<version>[1.7,)</version>
</requireJavaVersion>
<dependencyConvergence />

This comment was marked as spam.

</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>

This comment was marked as spam.

</executions>
</plugin>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>

This comment was marked as spam.

<version>2.6</version>
<configuration>
<archive>
<addMavenDescriptor>true</addMavenDescriptor>

This comment was marked as spam.

Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tldr; the merge pulled in a lot of things that may have been deleted before, or may not have existed before I don't know. This is one reason we should try really hard not to let PRs hang for this long. At this point, I don't even remember why I sent this PRm though I'm sure I had some reason.

@sduskis
Copy link
Contributor

sduskis commented Nov 8, 2018

@elharo, it looks like @garrettjonesgoogle has some questions about what the goal is. Can you please elaborate?

@chingor13
Copy link
Contributor

I'm going to close this out as it's unclear what this is trying to fix. Feel free to reopen with more information on the goal.

@chingor13 chingor13 closed this Nov 15, 2018
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
… to v2.32.0 (#3193)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[com.google.errorprone:error_prone_annotations](https://errorprone.info)
([source](https://redirect.github.com/google/error-prone)) | `2.31.0` ->
`2.32.0` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.errorprone:error_prone_annotations/2.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.errorprone:error_prone_annotations/2.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.errorprone:error_prone_annotations/2.31.0/2.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.errorprone:error_prone_annotations/2.31.0/2.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>google/error-prone
(com.google.errorprone:error_prone_annotations)</summary>

###
[`v2.32.0`](https://redirect.github.com/google/error-prone/releases/tag/v2.32.0):
Error Prone 2.32.0

[Compare
Source](https://redirect.github.com/google/error-prone/compare/v2.31.0...v2.32.0)

The minimum support JDK version to run Error Prone is now JDK 17
([#&#8203;3803](https://redirect.github.com/google/error-prone/issues/3803)).

Using Error Prone to compile code that is deployed to earlier versions
is still fully supported, but will requires using JDK 17 or newer for
compilation and setting `--release` or
`-source`/`-target`/`-bootclasspath`.

Full changelog:
google/error-prone@v2.31.0...v2.32.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/googleapis/sdk-platform-java).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43NC4xIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>2.46.0</summary>

##
[2.46.0](googleapis/sdk-platform-java@v2.45.0...v2.46.0)
(2024-09-23)


### Features

* expose property in GrpcTransportChannel if it uses direct path.
([#3170](googleapis/sdk-platform-java#3170))
([b20cec6](googleapis/sdk-platform-java@b20cec6))
* generate a GAPIC library from api definition
([#3208](googleapis/sdk-platform-java#3208))
([7070ed6](googleapis/sdk-platform-java@7070ed6))
* Metrics tracer addAttribute map overload
([#3202](googleapis/sdk-platform-java#3202))
([9d198a5](googleapis/sdk-platform-java@9d198a5))


### Bug Fixes

* generate pr description with repo level change
([#3182](googleapis/sdk-platform-java#3182))
([a6816c5](googleapis/sdk-platform-java@a6816c5))


### Dependencies

* update dependency com.google.errorprone:error_prone_annotations to
v2.32.0
([#3192](googleapis/sdk-platform-java#3192))
([130c97e](googleapis/sdk-platform-java@130c97e))
* update dependency com.google.errorprone:error_prone_annotations to
v2.32.0
([#3193](googleapis/sdk-platform-java#3193))
([ccbfbef](googleapis/sdk-platform-java@ccbfbef))
* update dependency filelock to v3.16.1
([#3210](googleapis/sdk-platform-java#3210))
([5c42420](googleapis/sdk-platform-java@5c42420))
* update dependency idna to v3.10
([#3201](googleapis/sdk-platform-java#3201))
([0d63eea](googleapis/sdk-platform-java@0d63eea))
* update dependency org.threeten:threetenbp to v1.7.0
([#3205](googleapis/sdk-platform-java#3205))
([376b0fa](googleapis/sdk-platform-java@376b0fa))
* update dependency org.threeten:threetenbp to v1.7.0
([#3206](googleapis/sdk-platform-java#3206))
([15e5806](googleapis/sdk-platform-java@15e5806))
* update dependency platformdirs to v4.3.3
([#3200](googleapis/sdk-platform-java#3200))
([f46bac5](googleapis/sdk-platform-java@f46bac5))
* update dependency platformdirs to v4.3.6
([#3209](googleapis/sdk-platform-java#3209))
([14a6f33](googleapis/sdk-platform-java@14a6f33))
* update dependency urllib3 to v2.2.3
([#3194](googleapis/sdk-platform-java#3194))
([9a4b6ae](googleapis/sdk-platform-java@9a4b6ae))
* update dependency virtualenv to v20.26.5
([#3212](googleapis/sdk-platform-java#3212))
([abf7d1d](googleapis/sdk-platform-java@abf7d1d))
* update google api dependencies
([#3183](googleapis/sdk-platform-java#3183))
([2d65010](googleapis/sdk-platform-java@2d65010))
* update google auth library dependencies to v1.26.0
([#3216](googleapis/sdk-platform-java#3216))
([b98a87b](googleapis/sdk-platform-java@b98a87b))
* update google auth library dependencies to v1.27.0
([#3221](googleapis/sdk-platform-java#3221))
([ea8c6b9](googleapis/sdk-platform-java@ea8c6b9))
* update googleapis/java-cloud-bom digest to 06f632d
([#3198](googleapis/sdk-platform-java#3198))
([ad37c6b](googleapis/sdk-platform-java@ad37c6b))
* update googleapis/java-cloud-bom digest to e7d8909
([#3207](googleapis/sdk-platform-java#3207))
([71eca2d](googleapis/sdk-platform-java@71eca2d))
* update opentelemetry-java monorepo to v1.42.1
([#3189](googleapis/sdk-platform-java#3189))
([d93a937](googleapis/sdk-platform-java@d93a937))
* Upgrade Protobuf-Java to v3.25.5
([#3217](googleapis/sdk-platform-java#3217))
([6e3c011](googleapis/sdk-platform-java@6e3c011))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants