Skip to content

feat(bigquery-jdbc): support picosecond in PreparedStatement parameters and batching - #14373

Merged
keshavdandeva merged 4 commits into
mainfrom
jdbc-picosecond-support-6
Sep 17, 2026
Merged

keshavdandeva merged 4 commits into
mainfrom
jdbc-picosecond-support-6

Conversation

@keshavdandeva

@keshavdandeva keshavdandeva commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

b/545231211

This PR adds picosecond timestamp support for PreparedStatement parameters and batch execution (EnableTimestampPicos=1), refactors statement pre-flight validation, and optimizes temporal string parsing.

Changes

  • BigQueryParameterHandler: Supported enableTimestampPicos to preserve up to 12 fractional digits without premature microsecond truncation, cleaned up constructors into a final-field telescoping chain, and deleted the unused 2-arg formatValueForQueryParameter overload.
  • BigQueryPreparedStatement: Propagated isEnableTimestampPicos across statement initialization and batch parameter handling (getStandardBatchJobConfiguration).
  • BigQueryStatement: Converted getJobConfig into a pure configuration builder and extracted statement checks into validateExecution().
  • BigQueryTemporalUtility: Consolidated fractional seconds truncation into a single helper (truncateFractionalSeconds) across all temporal parsers.
  • Unit Tests: Added coverage for high-precision parameter binding and batching, while deduplicating helper tests and removing dead mock stubs.

Key Architectural Decisions

1. Legacy SQL Exception & Pre-Flight Validation (BigQueryStatement)

  • Fail-Fast over Silent Data Loss: Legacy SQL cannot represent 12-digit picoseconds. Silently falling back to Legacy SQL would drop 6 decimal places of precision without warning. To prevent silent data corruption and maintain parity with other drivers, we fail execution explicitly.
  • Pre-Flight Placement: This check previously lived inside getJobConfig. A configuration builder should not enforce fatal query-blocking logic. Moving it to validateExecution() alongside checkClosed() ensures we fail fast at statement execution entry—avoiding false "Executing query..." logs and unnecessary OpenTelemetry trace spans.
  • Exception Classification: We intentionally use BigQueryJdbcException (general SQLException) instead of SQLSyntaxErrorException. The query itself (e.g., SELECT 1) is syntactically valid; the failure is a driver/session configuration conflict, not a SQL grammar defect.

2. ASCII Character Scanning Optimization (BigQueryTemporalUtility)

  • In truncateFractionalSeconds, we replaced Character.isDigit(c) with a direct ASCII check (c >= '0' && c <= '9') and cached str.length().
  • Because ISO-8601 and JDBC timestamp literals are strictly ASCII, avoiding Character.isDigit eliminates repeated Unicode table lookups and branching in the fractional scanning loop, reducing CPU overhead on hot result-set parsing paths.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for picosecond-precision timestamps in the BigQuery JDBC driver when enableTimestampPicos is enabled. It updates parameter formatting, adds execution validation to prevent using picosecond data with Legacy SQL, and refactors temporal utilities to support configurable fractional second truncation. The reviewer pointed out a potential bug where replacing all occurrences of 'T' with a space in timestamp strings could corrupt timezone names (e.g., "America/Toronto"), and suggested replacing 'T' only at the standard ISO-8601 separator position.

@keshavdandeva

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for picosecond timestamp precision in the BigQuery JDBC driver, controlled by the enableTimestampPicos flag. It refactors parameter handling and temporal utilities to dynamically truncate fractional seconds, and adds validation to prevent using picosecond precision with Legacy SQL. Feedback includes suggestions to robustly handle both uppercase and lowercase 'T' separators in ISO 8601 strings, and to add a guard clause against negative precision values in the truncation utility.

@keshavdandeva
keshavdandeva marked this pull request as ready for review September 14, 2026 15:31
@keshavdandeva
keshavdandeva requested review from a team as code owners September 14, 2026 15:31
@keshavdandeva
keshavdandeva added this pull request to stack #14393 September 15, 2026 19:25
@keshavdandeva
keshavdandeva force-pushed the jdbc-picosecond-support-6 branch from 4bf0283 to 8a88ea9 Compare September 17, 2026 13:22
@keshavdandeva
keshavdandeva force-pushed the jdbc-picosecond-support-6 branch from 8a88ea9 to 6bf664d Compare September 17, 2026 13:49
@keshavdandeva
keshavdandeva merged commit c1aac66 into main Sep 17, 2026
202 checks passed
@keshavdandeva
keshavdandeva deleted the jdbc-picosecond-support-6 branch September 17, 2026 14:43
blakeli0 pushed a commit that referenced this pull request Sep 23, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>1.92.0</summary>

##
[1.92.0](v1.91.0...v1.92.0)
(2026-09-23)


### Features

* **bigquery-jdbc:** add `EnableTimestampPicos` connection property and
its plumbing
([#14284](#14284))
([b4aa5ac](b4aa5ac))
* **bigquery-jdbc:** implement picosecond temporal math and formatting
engine
([#14286](#14286))
([2a9612a](2a9612a))
* **bigquery-jdbc:** support picosecond in REST JSON path and nested
types
([#14334](#14334))
([15ffe4a](15ffe4a))
* **bigquery-jdbc:** support picosecond in `PreparedStatement`
parameters and batching
([#14373](#14373))
([c1aac66](c1aac66))
* **bigquery-jdbc:** support picosecond timestamp in `ResultSetMetaData`
and `DatabaseMetaData`
([#14358](#14358))
([43acdd3](43acdd3))
* **bigquery-jdbc:** support picosecond timestamps in Arrow Storage Read
API and nested types
([#14332](#14332))
([b5d9aca](b5d9aca))
* **bigquery-jdbc:** support qualified project delimiter in
`DefaultDataset` property
([#14240](#14240))
([6e8d6c8](6e8d6c8))
* **bigquery:** accelerate row-based query() with Arrow wire format
([#14405](#14405))
([8d12a8f](8d12a8f))
* **bigquery:** add ArrowDeserializer helper utility
([#13943](#13943))
([d9a298b](d9a298b))
* **bigquery:** add ArrowQueryPageFetcher for Arrow query result
pagination
([#14404](#14404))
([615409f](615409f))
* **bigquery:** add ArrowQueryResult and ArrowQueryResultImpl for Arrow
result streaming
([#13944](#13944))
([a62fdf8](a62fdf8))
* **bigquery:** add Storage Read API slow-path fallback for row-based
query()
([#14409](#14409))
([26e568a](26e568a))
* **bigquery:** add zero-copy queryArrow API for Arrow VectorSchemaRoot
streaming
([#14402](#14402))
([b44ffe8](b44ffe8))
* **bigquery:** make BigQuery AutoCloseable with default no-op close
method
([#14434](#14434))
([00bf3de](00bf3de))
* **firestore:** add support for BSON types
([#13189](#13189))
([8a123d9](8a123d9))
* **gax:** add ApiCallContext and request-level settings overloads to
ResumableUploadCallable
([#14251](#14251))
([e8cbd42](e8cbd42))
* **gax:** add globalTimeout settings field to
ResumableUploadCallSettings
([#14253](#14253))
([438cda6](438cda6))
* **gax:** add resumable upload error classification and retry algorithm
([#14419](#14419))
([b70396d](b70396d))
* **gax:** add ResumableUploadCallable creation to Callables and
HttpJsonCallableFactory
([#14242](#14242))
([7de24de](7de24de))
* **gax:** implement baseline Callable and Future for resumable uploads
([#14241](#14241))
([5a54db9](5a54db9))
* **generator:** add model flag and allowlist parser for resumable
upload RPCs
([#14317](#14317))
([acc1856](acc1856))
* **generator:** emit resumable upload client surface
([#14319](#14319))
([a9fed00](a9fed00))
* **generator:** emit resumable upload settings and HttpJson upload stub
([#14321](#14321))
([c122474](c122474))
* **generator:** enable resumable upload generation for showcase
([#14325](#14325))
([f9ebd79](f9ebd79))
* **generator:** switch resumable upload specialized stubs to package
private
([#14471](#14471))
([0d4e875](0d4e875))
* **generator:** wire transport stub delegation to resumable upload
stubs
([#14322](#14322))
([cc4b980](cc4b980))
* **google/cloud/backupdr/v1beta:** add backupdr
([#14410](#14410))
([a4a47da](a4a47da))
* **google/cloud/networkservices/v1beta1:** add networkservices
([#14407](#14407))
([21c4955](21c4955))
* **pubsub:** add publish telemetry headers for publish attempt
observability
([#14338](#14338))
([c167ab8](c167ab8))
* **pubsub:** implement publish hedging to reduce tail latency
([#13735](#13735))
([b302615](b302615))
* **spanner:** Support dynamic TLS certificate and key rotation for
Spanner Omni
([#14456](#14456))
([ffc745c](ffc745c))
* **storage/control:** add delete folder recursive sample
([#13642](#13642))
([f4b1b46](f4b1b46))
* **storage/control:** add delete folder recursive sample
([#14397](#14397))
([2c01d55](2c01d55))


### Bug Fixes

* **auth:** restore transportFactory upon deserialization in
InternalAwsSecurityCredentialsSupplier
([#14340](#14340))
([beea42f](beea42f))
* **bigquery-jdbc:** ensure row ordering in PCNT IT
([#14330](#14330))
([a16f048](a16f048))
* **bigquery-jdbc:** fix htapi fallback due to permission logic
([#14418](#14418))
([21e6dc8](21e6dc8))
* **bigquery-jdbc:** fix Timestamp assertions
([#14290](#14290))
([533ba14](533ba14))
* **bigquery-jdbc:** handle null parameters in Storage Write API bulk
inserts
([#14270](#14270))
([dd2c41a](dd2c41a)),
refs
[#14066](#14066)
* **bigquery-jdbc:** handle SQL NULLs in ResultSet primitive getters
([#14383](#14383))
([8e464fe](8e464fe)),
refs
[#14371](#14371)
* **bigquery:** default Arrow pagination stream location to US instead
of global
([#14458](#14458))
([2775eb1](2775eb1))
* **bigquery:** preserve page token and paginate correctly in Arrow
query when maxResults is set
([#14469](#14469))
([f5601f4](f5601f4))
* **bigquery:** use first page row count for Arrow query pagination
offset
([#14466](#14466))
([9d10dd0](9d10dd0))
* **bigtable:** don't notify config listeners while holding the manager
lock
([#14294](#14294))
([4426ccd](4426ccd))
* **bigtable:** fall back to classic path when per-RPC CallCredentials
are set on session path
([#14477](#14477))
([57bacb0](57bacb0))
* **bigtable:** fix abnormal session closures and scale-up in session
pool
([#14431](#14431))
([6361ecd](6361ecd))
* **biqguery:** fix undeclared QueryParameter wiring in QueryStatistics
([#14401](#14401))
([64cf1d3](64cf1d3))
* **bom:** restore google-cloud-spanner-jdbc to libraries-bom
([#14362](#14362))
([bc7be5e](bc7be5e)),
refs
[#14347](#14347)
* **spanner:** honor maxAttempts and totalTimeout in streaming resume
loop
([#14370](#14370))
([305f47d](305f47d))
* **spanner:** only set snapshot isolation read timestamp for SI or
optimistic txns in CloudClientExecutor
([#14346](#14346))
([54c0d0f](54c0d0f))
* **spanner:** prevent statement cancellation race in
AbstractBaseUnitOfWork
([#14283](#14283))
([d9a8eef](d9a8eef))
* **spanner:** re-enable ITInstanceAdminTest on cloud-devel and
cloud-staging
([#14281](#14281))
([89a8268](89a8268))


### Performance Improvements

* **spanner:** stop re-parsing the request id on every RPC
([#14353](#14353))
([46108f4](46108f4))


### Documentation

* Add a Http/Json Post-Quantum Cryptography Guide
([#13963](#13963))
([fcc65b0](fcc65b0))
* **bigquery:** add QueryArrow code sample and document JDK 17+ JVM
requirements
([#14437](#14437))
([bd363f6](bd363f6))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants