test(spanner): unflake ITTransactionRetryTest on Spanner Omni - #14372
Merged
Merged
Conversation
Align com.google.cloud.spanner.connection.it.ITTransactionRetryTest with the existing skip precedent in ITRetryDmlAsPartitionedDmlTest and com.google.cloud.spanner.ITTransactionRetryTest by skipping on Spanner Omni due to known issue b/441255724. Also correct the copy-pasted DirectPath bug reference in the other tests.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the bug reference ID for skipping Spanner Omni tests across several integration test files and adds a new @BeforeClass setup method to ITTransactionRetryTest to skip tests on Spanner Omni. However, the newly added setup() method calls ITAbstractSpannerTest.setup(), which throws Exception. This will cause a compilation error unless the method signature is updated to declare throws Exception or the call is wrapped in a try-catch block.
sagnghos
approved these changes
Sep 14, 2026
rahul2393
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align
com.google.cloud.spanner.connection.it.ITTransactionRetryTestwith the existing skip precedent inITRetryDmlAsPartitionedDmlTestandcom.google.cloud.spanner.ITTransactionRetryTestby skipping on Spanner Omni due to known issue b/441255724. Also correct the copy-pasted DirectPath bug reference in the other tests.