Skip to content

chore(librarian): remove min_java_version from spanner config - #14365

Merged
zhumin8 merged 1 commit into
googleapis:mainfrom
zhumin8:remove-min-java-version
Sep 14, 2026
Merged

zhumin8 merged 1 commit into
googleapis:mainfrom
zhumin8:remove-min-java-version

Conversation

@zhumin8

@zhumin8 zhumin8 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Remove redundant min_java_version field from spanner's library configuration. The field is obsolete and defaults to 8 in librarian.

For googleapis/librarian#6693

Remove redundant min_java_version field from spanner's library configuration.
The field is obsolete and defaults to 8 in librarian.

For googleapis/librarian#6693

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the min_java_version: 8 configuration for the Cloud Spanner library in librarian.yaml. I have no feedback to provide as there are no review comments.

@zhumin8
zhumin8 marked this pull request as ready for review September 14, 2026 15:03
@zhumin8
zhumin8 requested review from a team as code owners September 14, 2026 15:03
@zhumin8
zhumin8 merged commit c5229b4 into googleapis:main Sep 14, 2026
196 checks passed
zhumin8 added a commit that referenced this pull request Sep 14, 2026
)

Remove obsolete min_java_version field from spanner's
.repo-metadata.json, this was earlier missed in #14365.

For googleapis/librarian#6693
zhumin8 added a commit to googleapis/librarian that referenced this pull request Sep 21, 2026
…ault (#7633)

The `min_java_version` configuration is moved from per-library
JavaModule and .repo-metadata.json to JavaDefault (default.java in
librarian.yaml).

When unspecified in the repository default, it falls back to 8 for
README generation.

This change should not affect google-cloud-java, as the only per-library
`min_java_version` is removed in
googleapis/google-cloud-java#14365.

For #6693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants