Skip to content

chore(ci): remove cron schedule and issue creation from showcase version check - #14356

Merged
zhumin8 merged 5 commits into
googleapis:mainfrom
zhumin8:showcase-check-remove-cron
Sep 11, 2026
Merged

zhumin8 merged 5 commits into
googleapis:mainfrom
zhumin8:showcase-check-remove-cron

Conversation

@zhumin8

@zhumin8 zhumin8 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

The scheduled job is redundant as the presubmit check is required.

Without this change, there is a bug in the workflow that also creates an issue when this check fails at presubmit (see #14298). Instead of fixing the immediate issue, we are deleting the cron job and simplify this workflow.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@zhumin8
zhumin8 marked this pull request as ready for review September 11, 2026 16:02
@zhumin8
zhumin8 requested review from a team as code owners September 11, 2026 16:02
@zhumin8

zhumin8 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

hmm, looks like the filter logic in ci.yaml is not preventing required skip checks from blocking this PR
image

@zhumin8

zhumin8 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Required checks units (11) ... units (26) were missing and blocking this PR. In GitHub Actions, having if: runnable == 'true' at the job level skips units before matrix expansion, so the individual matrix check runs are never created or reported to branch protection.

Removing the job-level if allows the matrix to expand. When changes are limited to workflow files, the test execution step
(.kokoro/build.sh) is still guarded and skipped by its step-level if, allowing the matrix jobs to complete quickly and satisfy branch protection.

Testing the fix here to validate.

@zhumin8

zhumin8 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Pushed a temp change to not trigger full unit test run for ci.yaml change, verified now the heavy lifting in unit tests are skipped as expected and not blocking the workflow change PR (https://github.com/googleapis/google-cloud-java/actions/runs/34647959284/job/103423451335).
Then reverted this temp change in d93cc12

We should be free to merge this change in when CI passes.

@zhumin8
zhumin8 enabled auto-merge (squash) September 11, 2026 21:19
@zhumin8
zhumin8 merged commit be3d80d into googleapis:main Sep 11, 2026
198 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants