Skip to content

testlib and junit #5646

Description

@elharo

In google-cloud-client/pom.xml I noticed this:

     <!-- testlib deps. Only put testlib dependencies here, which are testlib packages
      that correspond to another non-test package. Put pure test dependencies (e.g.
      junit) in the main pom.xml. -->
      <dependency>
        <groupId>com.google.guava</groupId>
        <artifactId>guava-testlib</artifactId>
        <version>${guava.version}</version>
      </dependency>
      <dependency>
        <groupId>junit</groupId>
        <artifactId>junit</artifactId>
        <version>4.12</version>
</dependency>

Either the comment is wrong or misplaced or junit should not be included here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions