Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

chore: update CHANGELOG for release#1459

Merged
scotthart merged 2 commits intogoogleapis:masterfrom
scotthart:release_202004
Apr 1, 2020
Merged

chore: update CHANGELOG for release#1459
scotthart merged 2 commits intogoogleapis:masterfrom
scotthart:release_202004

Conversation

@scotthart
Copy link
Copy Markdown
Member

@scotthart scotthart commented Apr 1, 2020

This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2020
Copy link
Copy Markdown
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make a pass and remove anything that should be of no interest to the users (changes in internal, tests, the CI stuff, etc.)

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 11 unresolved discussions (waiting on @devbww, @devjgm, @mr-salty, and @scotthart)


CHANGELOG.md, line 11 at r1 (raw file):

* **Other Changes**
  * chore: update g-c-cpp-common to v0.25.0 (#1458)

We typically do not include chore items in the user-facing release notes.


CHANGELOG.md, line 12 at r1 (raw file):

* **Other Changes**
  * chore: update g-c-cpp-common to v0.25.0 (#1458)
  * feat: provide a mockable `Clock` class (#1452)

I would remove this, changes in internal should not be interesting.


CHANGELOG.md, line 13 at r1 (raw file):

  * chore: update g-c-cpp-common to v0.25.0 (#1458)
  * feat: provide a mockable `Clock` class (#1452)
  * fix: change include guard prefix to GOOGLE_CLOUD_CPP_ (#1456)

Sam thing.


CHANGELOG.md, line 15 at r1 (raw file):

  * fix: change include guard prefix to GOOGLE_CLOUD_CPP_ (#1456)
  * feat: announce move to monorepo (#1455)
  * fix: made .clang-format generic for any repo (#1454)

I would remove this.


CHANGELOG.md, line 18 at r1 (raw file):

  * feat: allow for the emulator in ClientIntegrationTest.QueryOptionsWork (#1453)
  * docs: add snippets for methods and classes in keys.h (#1451)
  * cleanup: eliminate an unnecessary local variable (#1450)

I do not think the users care about this.


CHANGELOG.md, line 20 at r1 (raw file):

  * cleanup: eliminate an unnecessary local variable (#1450)
  * doc: add mention of GOOGLE_CLOUD_CPP_TRACING_OPTIONS env var (#1448)
  * chore: remove some unncessary NOLINTs (#1447)

Ditto.


CHANGELOG.md, line 21 at r1 (raw file):

  * doc: add mention of GOOGLE_CLOUD_CPP_TRACING_OPTIONS env var (#1448)
  * chore: remove some unncessary NOLINTs (#1447)
  * ci: use build cache for ci/kokoro/docker builds (#1446)

Same thing.


CHANGELOG.md, line 23 at r1 (raw file):

  * ci: use build cache for ci/kokoro/docker builds (#1446)
  * test: write integration test for SessionPool (#1442)
  * test: reduce running time of SessionPool.SessionRefresh (16s to 2s) (#1445)

Same here.


CHANGELOG.md, line 24 at r1 (raw file):

  * test: write integration test for SessionPool (#1442)
  * test: reduce running time of SessionPool.SessionRefresh (16s to 2s) (#1445)
  * cleanup: remove dead code from SpannerStub (#1444)

This is also uninteresting to the users I think.


CHANGELOG.md, line 30 at r1 (raw file):

  * feat: add overloads to admin connections for specifying policies (#1439)
  * feat: change quickstart to use recommended build target (#1436)
  * fix: typo in dox (#1434)

I would skip this.


CHANGELOG.md, line 31 at r1 (raw file):

  * feat: change quickstart to use recommended build target (#1436)
  * fix: typo in dox (#1434)
  * chore: update version numbers after v1.0.0 (#1433)

we usually skip this one.

Comment thread CHANGELOG.md
## v1.2.0 - TBD

## v1.1.0 - 2020-04

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to include the following here:

> **NOTICE:** This repo will be merging with the
[googleapis/google-cloud-cpp](https://github.com/googleapis/google-cloud-cpp)
monorepo in 60 days, around **June 1, 2020**. This change should not break any
users who are using a released version. We expect this new monorepo
organization to be better for our existing and new customers going forward.
Please see
[googleapis/google-cloud-cpp#3612](https://github.com/googleapis/google-cloud-cpp/issues/3612)
for more details.

This will match what we did in -common

Copy link
Copy Markdown
Member Author

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 12 unresolved discussions (waiting on @coryan, @devbww, @devjgm, and @mr-salty)


CHANGELOG.md, line 6 at r1 (raw file):

Previously, devjgm (Greg Miller) wrote…

I think you want to include the following here:

> **NOTICE:** This repo will be merging with the
[googleapis/google-cloud-cpp](https://github.com/googleapis/google-cloud-cpp)
monorepo in 60 days, around **June 1, 2020**. This change should not break any
users who are using a released version. We expect this new monorepo
organization to be better for our existing and new customers going forward.
Please see
[googleapis/google-cloud-cpp#3612](https://github.com/googleapis/google-cloud-cpp/issues/3612)
for more details.

This will match what we did in -common

Done.


CHANGELOG.md, line 11 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

We typically do not include chore items in the user-facing release notes.

Done.


CHANGELOG.md, line 12 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

I would remove this, changes in internal should not be interesting.

Done.


CHANGELOG.md, line 13 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

Sam thing.

Done.


CHANGELOG.md, line 15 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

I would remove this.

Done.


CHANGELOG.md, line 18 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

I do not think the users care about this.

Done.


CHANGELOG.md, line 20 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

Ditto.

Done.


CHANGELOG.md, line 21 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

Same thing.

Done.


CHANGELOG.md, line 23 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

Same here.

Done.


CHANGELOG.md, line 24 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

This is also uninteresting to the users I think.

Done.


CHANGELOG.md, line 30 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

I would skip this.

Done.


CHANGELOG.md, line 31 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

we usually skip this one.

Done.

Copy link
Copy Markdown
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @devbww, @devjgm, @mr-salty, and @scotthart)


CHANGELOG.md, line 6 at r2 (raw file):

## v1.1.0 - 2020-04
> **NOTICE:** This repo will be merging with the

nit: blank line before the notice?


CHANGELOG.md, line 25 at r2 (raw file):

  * test: write integration test for SessionPool (#1442)
  * doc: snippets for admin clients with custom policies (#1440)
  * testing: improvements for Backup related tests (#1438)

nit: I would skip this one and the next tpp

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2020

Codecov Report

Merging #1459 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1459      +/-   ##
==========================================
+ Coverage   95.57%   95.61%   +0.03%     
==========================================
  Files         192      191       -1     
  Lines       15830    15833       +3     
==========================================
+ Hits        15130    15138       +8     
+ Misses        700      695       -5
Impacted Files Coverage Δ
google/cloud/spanner/internal/log_wrapper.h 75% <0%> (-9.62%) ⬇️
google/cloud/spanner/internal/polling_loop.h 83.33% <0%> (-9.53%) ⬇️
google/cloud/spanner/client.cc 96.91% <0%> (-0.62%) ⬇️
google/cloud/spanner/internal/session.h 100% <0%> (ø) ⬆️
google/cloud/spanner/session_pool_options.h 100% <0%> (ø) ⬆️
google/cloud/spanner/internal/spanner_stub.cc 77.41% <0%> (ø) ⬆️
...oogle/cloud/spanner/internal/database_admin_stub.h
.../spanner/benchmarks/multiple_rows_cpu_benchmark.cc 91.97% <0%> (ø) ⬆️
...anner/integration_tests/client_integration_test.cc 97.79% <0%> (+0.01%) ⬆️
google/cloud/spanner/samples/samples.cc 90.34% <0%> (+0.32%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e481273...2087863. Read the comment docs.

@scotthart scotthart merged commit 27cc2b1 into googleapis:master Apr 1, 2020
scotthart added a commit to scotthart/google-cloud-cpp-spanner that referenced this pull request Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants