This repository was archived by the owner on Dec 8, 2021. It is now read-only.
chore: add some async methods to SpannerStub#1270
Merged
Merged
Conversation
googlebot
added
the
cla: yes
devjgm
approved these changes
Feb 18, 2020
devbww
approved these changes
Feb 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #1270 +/- ##
=========================================
- Coverage 94.85% 94.6% -0.26%
=========================================
Files 181 180 -1
Lines 13813 13865 +52
=========================================
+ Hits 13103 13117 +14
- Misses 710 748 +38
Continue to review full report at Codecov.
|
the "break" is adding pure virtual methods to an internal object (`SpannerStub`), so it's not actually a break.
devjgm
pushed a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…ud-cpp-spanner#1270) * chore: add some async methods to SpannerStub These are only for use by `SessionPool`; we are not exposing any async APIs to users at this time. Part of googleapis/google-cloud-cpp-spanner#1171 and googleapis/google-cloud-cpp-spanner#1172 * ABI/API update the "break" is adding pure virtual methods to an internal object (`SpannerStub`), so it's not actually a break.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are only for use by
SessionPool; we are not exposing any asyncAPIs to users at this time.
Part of #1171 and #1172
This change is