This repository was archived by the owner on Dec 8, 2021. It is now read-only.
refactor!: prepare for new field in SqlParams#1265
Merged
Conversation
We're going to be adding a new field to SqlParams fairly soon, so to prevent an API break later, this PR adds a dummy field in the struct so that we can take the API breakage now rather than later. The struct field is named such that users *should* not use it by name, but its existence should require that it gets default initialized.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1265 +/- ##
==========================================
- Coverage 94.95% 94.82% -0.13%
==========================================
Files 185 185
Lines 13814 13817 +3
==========================================
- Hits 13117 13102 -15
- Misses 697 715 +18
Continue to review full report at Codecov.
|
coryan
approved these changes
Feb 13, 2020
devjgm
added a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
…d-cpp-spanner#1265) We're going to be adding a new field to SqlParams fairly soon, so to prevent an API break later, this PR adds a dummy field in the struct so that we can take the API breakage now rather than later. The struct field is named such that users *should* not use it by name, but its existence should require that it gets default initialized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're going to be adding a new field to SqlParams fairly soon, so to
prevent an API break later, this PR adds a dummy field in the struct so
that we can take the API breakage now rather than later. The struct
field is named such that users should not use it by name, but its
existence should require that it gets default initialized.
This change is