This repository was archived by the owner on Dec 8, 2021. It is now read-only.
cleanup: remove underscores from TEST names#1151
Merged
Conversation
googlebot
added
the
cla: yes
devbww
approved these changes
Dec 15, 2019
Contributor
devbww
left a comment
devbww
left a comment
There was a problem hiding this comment.
I'm not sure why the tests don't run, but it LGTM so I'm happy to approve and merge. Thanks.
Author
|
Wdym the tests don't run? Are you talking about the Kokoro builds or the tests themselves? |
Contributor
The Kokoro builds. |
Author
|
I think you need to add the |
devjgm
pushed a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1144
This change is