You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 8, 2021. It is now read-only.
This is the return value of both Client::Read and Client::ExecuteQuery, so there's no reason to associate the class name more with one of those functions in particular.
After feat!: support for select-star queries #976QueryResult itself has begin() and end() member functions so it can itself be iterated directly. Therefore, it kinda makes sense to include the word "range" or "stream" in the class's name. (Note: I've been preferring the word "stream" here, e.g., RowStreamIterator, in the general sense of an unknown source of data that might break at some point, not in the "iostreams" sense).
The iterators returned by begin() and end() are named RowStreamIterator
Logically the main thing encapsulated by this object is that it represents a stream of Row objects. The only other method it has is ReadTimestamp(), which still seems to fit fine.
Reasons to rename:
This is the return value of both
Client::ReadandClient::ExecuteQuery, so there's no reason to associate the class name more with one of those functions in particular.After feat!: support for select-star queries #976
QueryResultitself hasbegin()andend()member functions so it can itself be iterated directly. Therefore, it kinda makes sense to include the word "range" or "stream" in the class's name. (Note: I've been preferring the word "stream" here, e.g.,RowStreamIterator, in the general sense of an unknown source of data that might break at some point, not in the "iostreams" sense).The iterators returned by
begin()andend()are namedRowStreamIteratorLogically the main thing encapsulated by this object is that it represents a stream of
Rowobjects. The only other method it has isReadTimestamp(), which still seems to fit fine.I'm all for this rename.