Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

consider renaming QueryResult -> RowStream #977

@devjgm

Description

@devjgm

Reasons to rename:

  1. This is the return value of both Client::Read and Client::ExecuteQuery, so there's no reason to associate the class name more with one of those functions in particular.

  2. After feat!: support for select-star queries #976 QueryResult itself has begin() and end() member functions so it can itself be iterated directly. Therefore, it kinda makes sense to include the word "range" or "stream" in the class's name. (Note: I've been preferring the word "stream" here, e.g., RowStreamIterator, in the general sense of an unknown source of data that might break at some point, not in the "iostreams" sense).

  3. The iterators returned by begin() and end() are named RowStreamIterator

  4. Logically the main thing encapsulated by this object is that it represents a stream of Row objects. The only other method it has is ReadTimestamp(), which still seems to fit fine.

I'm all for this rename.

Metadata

Metadata

Assignees

Labels

api: spannerIssues related to the googleapis/google-cloud-cpp-spanner API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions