This repository was archived by the owner on Dec 8, 2021. It is now read-only.
fix: correct range validation in ParseRfc3339#220
Merged
coryan merged 1 commit intogoogleapis:v0.22.xfrom Mar 10, 2020
coryan:prepare-v0.22.1-patch
Merged
fix: correct range validation in ParseRfc3339#220coryan merged 1 commit intogoogleapis:v0.22.xfrom coryan:prepare-v0.22.1-patch
coryan merged 1 commit intogoogleapis:v0.22.xfrom
coryan:prepare-v0.22.1-patch
Conversation
It was not accepting 59 as a valid minute, this bug was introduced in the clang-tidy cleanup, and our tests validate that things *outside* the valid ranges are correctly reported as errors, but not that things *exactly* at the boundary conditions are reported as valid. Sigh.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## v0.22.x #220 +/- ##
===========================================
- Coverage 96.28% 96.26% -0.02%
===========================================
Files 97 97
Lines 4443 4447 +4
===========================================
+ Hits 4278 4281 +3
- Misses 165 166 +1
Continue to review full report at Codecov.
|
Contributor
|
Oh ... I see ... it is a cherrypick into a branch. |
devbww
approved these changes
Mar 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was not accepting 59 as a valid minute, this bug was introduced in
the clang-tidy cleanup, and our tests validate that things outside the
valid ranges are correctly reported as errors, but not that things
exactly at the boundary conditions are reported as valid. Sigh.
I ran the
clang-tidybuild forg-c-cppandg-c-cpp-spanneragainstthese changes, the build passed in both cases.
This change is