Skip to content

Prepare py3 - #25

Merged
nathanielmanistaatgoogle merged 4 commits into
googleapis:masterfrom
methane:prepare-py3
Mar 3, 2015
Merged

nathanielmanistaatgoogle merged 4 commits into
googleapis:masterfrom
methane:prepare-py3

Conversation

@methane

@methane methane commented Aug 20, 2014

Copy link
Copy Markdown
Contributor

Safe changes via 2to3 and futurize.

@hgrecco

hgrecco commented Nov 6, 2014

Copy link
Copy Markdown

What is the status of this?

@methane

methane commented Nov 8, 2014

Copy link
Copy Markdown
Contributor Author

This branch only automated changes. They are simple, easy to review, but massive.
Since Python 3 support may take long time to be merged into master,
I want to this branch is merged into master before creating "python3" branch to avoid many conflicts.

@methane

methane commented Nov 8, 2014

Copy link
Copy Markdown
Contributor Author

@craigcitro Could some googler review this?
This PR is middle sized, but should be safe and easy to review.

@icoxfog417 icoxfog417 mentioned this pull request Nov 11, 2014
@methane methane mentioned this pull request Mar 3, 2015
@nathanielmanistaatgoogle

Copy link
Copy Markdown
Contributor

@craigcitro this looks good to me; do you want to be another set of eyes reviewing?

@craigcitro

Copy link
Copy Markdown
Contributor

LGTM

nathanielmanistaatgoogle added a commit that referenced this pull request Mar 3, 2015
@nathanielmanistaatgoogle
nathanielmanistaatgoogle merged commit 15fbdc7 into googleapis:master Mar 3, 2015
@methane
methane deleted the prepare-py3 branch March 3, 2015 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants