fix: update deprecated utcnow, utcfromtimestamp - #2286
Merged
Conversation
vchudnov-g
changed the title
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Contributor
|
Thanks for the PR, @salty-horse ! Could you link to the docs to which you refer that need updating? |
Contributor
Author
|
The epy-generated docs for the two files I changed, which mention the old value of |
parthea
approved these changes
Dec 12, 2023
parthea
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
parthea
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
Contributor
|
I filed #2300 to track the issue with the outdated docs |
Scoring100
suggested changes
Jan 21, 2024
| @@ -46,7 +46,7 @@ | |||
| LOGGER = logging.getLogger(__name__) | |||
| @@ -2193,7 +2193,7 @@ def _dummy_token(self): | |||
| client_id = "some_client_id" | |||
| client_secret = "cOuDdkfjxxnv+" | |||
There was a problem hiding this comment.
Suggested change
| client_secret = "cOuDdkfjxxnv+" | |
| client_secret = "cOuDdkfjxxnv+"`` |
| @@ -2193,7 +2193,7 @@ def _dummy_token(self): | |||
| client_id = "some_client_id" | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2285 🦕
The docs should be regenerated, since they mention the
EPOCHconstants. I'm not sure how to do that :(