This repository was archived by the owner on Feb 18, 2024. It is now read-only.
Refactor, simplify and modernize GCS sample#1
Closed
Capstan wants to merge 11 commits intogoogle:masterfrom
Closed
Refactor, simplify and modernize GCS sample#1Capstan wants to merge 11 commits intogoogle:masterfrom
Capstan wants to merge 11 commits intogoogle:masterfrom
Conversation
Pull up api client dependencies to associated 1.20.0 version and update Guava to latest, 18.0.
* Break up the monolithic file into individual standalone examples that can be executed separately. * Move some helper classes into separate files for brevity. * Remove some of the complexity to avoid barriers to entry.
Since API client includes Guava, its version obscures the explicit dependency.
Don’t track Eclipse-generated directories.
From comments on https://codereview.appspot.com/236910043/ patch set 1.
Capstan
changed the title
Conform to 100 character line lengths and add JavaDoc to top-level classes. While here, also fixed the Application names of two of the examples to match the class name.
Change references from mercurial to git, and update the developer console URL to the modern use.
Contributor
Author
|
Everyone has LGTMed the code review, so this pull request is ready for inclusion. |
Contributor
Author
|
Committed in af27369683. |
Contributor
Author
|
@wonderfly I think that, despite you having already committed these changes in some kind of commit, this pull request isn't resolved, since I'm perennially showing these diffs between my master (which has no further changes) and google/master. I think merging this would be a no-op for code differences, but maybe fix the git accounting in some fashion I do not yet fully comprehend. |
|
The change was cherry-picked. That keeps the git history clean and removes all the review noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://codereview.appspot.com/236910043/
googleapis/google-api-java-client#938