This repository was archived by the owner on Oct 19, 2023. It is now read-only.
Repository navigation
Improve Message() and MessageSet() objects to better match the API specs and fix imports - #3
Merged
Merged
Conversation
edonosotti
commented
Nov 22, 2017
edonosotti
commented
Contributor
- [FIX] some imports were not working correctly when running unit tests from the repository root
- [IMPROVEMENT] expose all API "/message" properties in Message object
- [IMPROVEMENT] expose all Message object properties in MessageSet.new_message() method
- [IMPROVEMENT] add MessageSet.append_message() method
- update README files to reflect changes
- expose all Message object properties in MessageSet.new_message() method - add MessageSet.append_message() method - update README files
Contributor
Author
|
Glad you liked it ;) |
|
@edonosotti Even the changes are backward compatible, minor version bump will be a good idea. |
nori0990
approved these changes
Dec 10, 2017
Contributor
|
@edonosotti Thanks for the contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.